Fix instance store race condition, hardcoded URL, and minor issues#2778
Merged
Conversation
- Fix race condition in instance store: deduplicate concurrent fetchInstanceInfo() calls by tracking an in-flight promise - Fix remaining hardcoded dandiarchive.org URL in HowToCiteTab dandiUrl computed property — now uses instanceStore.instanceUrl - Initialize instance store at app startup in main.ts so page titles work on all routes, not just those mounting specific components - Reorder DownloadDialog.vue onMounted to use cached instance store fetch before calling dandiRest.info() for CLI version info - Fix snake_case local variables in HowToCiteTab to use camelCase - Use POSIX-portable [[:space:]] instead of \s in lint script grep - Add resp.ok check in E2E fetchInstanceConfig for clearer errors Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yarikoptic
reviewed
Apr 9, 2026
| vancouver: cffToVancouver(cffObject.value, instanceName.value), | ||
| ieee: cffToIEEE(cffObject.value, instanceName.value), | ||
| bibtex: cffToBibTeX(cffObject.value, dandisetVersionIdentifier.value, instanceName.value), | ||
| ris: cffToRIS(cffObject.value, dandisetVersionIdentifier.value, instanceName.value), |
Member
There was a problem hiding this comment.
imho it was better before - shorter variables made it easier to read... rationale is not listed among items -- do you see what it was ?
Member
Author
There was a problem hiding this comment.
snake_case → camelCase
Member
|
I will merge, although that dance with variables isn't clear to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes for #2765:
fetchInstanceInfo()calls from multiple components now share a single in-flight promise instead of firing duplicate/api/info/requestsdandiUrlcomputed property was still falling back tohttps://dandiarchive.org— now usesinstanceStore.instanceUrlmain.tsso page titles work on all routes (not just those mounting components that callfetchInstanceInfo())dandiRest.info()call for CLI version info\swith[[:space:]]in lint script for BSD grep compatibilityresp.okcheck infetchInstanceConfig()Test plan
npm run lintpassesnpm run type-checkpasses🤖 Generated with Claude Code