Make Related resource titles clickable links on Dandiset landing page#2838
Open
kabilar wants to merge 2 commits into
Open
Make Related resource titles clickable links on Dandiset landing page#2838kabilar wants to merge 2 commits into
Related resource titles clickable links on Dandiset landing page#2838kabilar wants to merge 2 commits into
Conversation
Member
Author
|
Preview that displays a resource with a URL and one without a URL: |
Member
|
I like this idea. My only minor request is that I don't really like the default styling for links and I think we should follow the styling in https://docs.dandiarchive.org/ |
Use the link styling from the documentation site (Material for MkDocs): indigo (#4051b5), no underline, with a smooth transition to a lighter blue (#0091eb) on hover/focus, instead of the default underlined link. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I have been on calls where users who were navigating the DLP didn't see the link icon that is off to the right of the resource.
Changes
Here I propose making the related resource titles clickable links that open in a new tab and removing the link icon.
cc @satra @ayendiki