Skip to content

1676 kmeans spectral#1688

Open
k034b363 wants to merge 89 commits into
v5.0from
1676-kmeans-spectral
Open

1676 kmeans spectral#1688
k034b363 wants to merge 89 commits into
v5.0from
1676-kmeans-spectral

Conversation

@k034b363
Copy link
Copy Markdown
Contributor

@k034b363 k034b363 commented Apr 1, 2025

Describe your changes
This PR adds the option to use hyperspectral images as input for kmeans clustering. It has been suggested that using more bands might help distinguish plant features that are otherwise difficult to tell apart.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
Closes #1682 and #1676

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@k034b363 k034b363 added enhancement Enhancements to existing features work in progress Mark work in progress labels Apr 1, 2025
@k034b363 k034b363 added this to the PlantCV v4.x milestone Apr 1, 2025
@k034b363 k034b363 self-assigned this Apr 1, 2025
@k034b363 k034b363 linked an issue Apr 1, 2025 that may be closed by this pull request
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Apr 1, 2025

DeepSource Code Review

We reviewed changes in a3a0eab...59ccad0 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Mar 20, 2026 2:12p.m. Review ↗
Test coverage Mar 20, 2026 2:12p.m. Review ↗

@joshqsumner joshqsumner changed the base branch from main to v5.0 February 6, 2026 21:38
@joshqsumner
Copy link
Copy Markdown
Contributor

I merged some stuff into this to be downstream of image-sharpening where I had split params and outputs into a _globals module to define singletons with less chance for import complaints which also points this at v5.

joshqsumner and others added 27 commits February 6, 2026 15:45
Updated Fs frame labels to Fdarksat and Flightsat for PAM protocols
Add the geospatial extension to the documentation table of contents
Update documentation and project files to use custom domain for documentation
Update open_url test to use self hosted image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancements to existing features work in progress Mark work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow kmeans to use hyper spectral images Kmeans training step should check for numpy arrays

4 participants