Skip to content

Make analyze.texture#1896

Open
joshqsumner wants to merge 19 commits into
v5.0from
make-analyze.texture
Open

Make analyze.texture#1896
joshqsumner wants to merge 19 commits into
v5.0from
make-analyze.texture

Conversation

@joshqsumner
Copy link
Copy Markdown
Contributor

Describe your changes
Added an analyze.texture module per #1895

Type of update
This is a new feature.

Associated issues
Closes #1895

Additional context
Not totally sold on returning the GLCM from the last object as the debug image but I don't really have a better idea right now. Definitely open to other ideas.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added the new feature New feature ideas and solutions label Mar 26, 2026
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Mar 26, 2026

DeepSource Code Review

We reviewed changes in a686623...99f1a68 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Apr 10, 2026 8:45p.m. Review ↗
Test coverage Apr 10, 2026 8:45p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
[✓ above threshold]
99.9%
[▼ down 0.1% from main]
Python
100%
[✓ above threshold]
99.9%
[▼ down 0.1% from main]

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new plantcv.analyze.texture analysis module (requested in #1895) to compute texture phenotypes for labeled objects using GLCM-based metrics, and exposes it through the public plantcv.analyze namespace with accompanying docs and tests.

Changes:

  • Introduces plantcv/plantcv/analyze/texture.py implementing texture() and a debug plot generator.
  • Adds unit tests for default level inference and basic texture output recording.
  • Adds documentation + navigation updates (MkDocs) and an example debug image asset.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
plantcv/plantcv/analyze/texture.py New texture analysis implementation and Altair debug plot generation.
tests/plantcv/analyze/test_texture.py New tests covering _default_levels and texture() basic behavior.
plantcv/plantcv/analyze/__init__.py Exposes texture via plantcv.analyze.
mkdocs.yml Adds “Analyze Texture” to docs navigation.
docs/analyze_texture.md New user-facing documentation for plantcv.analyze.texture.
docs/updating.md Adds API entry for the new function.
docs/img/documentation_images/analyze_texture/texture_debug.png Adds a documentation/debug image asset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plantcv/plantcv/analyze/texture.py
Comment thread plantcv/plantcv/analyze/texture.py
Comment thread plantcv/plantcv/analyze/texture.py Outdated
Comment thread plantcv/plantcv/analyze/texture.py Outdated
Comment thread plantcv/plantcv/analyze/texture.py
Comment thread tests/plantcv/analyze/test_texture.py Outdated
Comment thread tests/plantcv/analyze/test_texture.py
Comment thread docs/updating.md Outdated
Comment thread docs/analyze_texture.md Outdated
Comment thread docs/analyze_texture.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature ideas and solutions ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants