ci: multi-target IntegrationTests across net8/net9/net10#73
Merged
Conversation
The CI matrix added in #66 silently skipped IntegrationTests on net8/net9 because the project was net10-only. That meant the library's own net8/net9 TFM-conditional code paths (Npgsql.EntityFrameworkCore.PostgreSQL 8.x/9.x) went untested end-to-end. Match the unit Tests project pattern: - <TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks> - Conditional package references pinning Npgsql.EFCore to the matching 8.0.11 / 9.0.4 / 10.0.1 release per TFM (same scheme the library uses). - <LangVersion>latest</LangVersion> so the C# 14 compiler is used on every TFM — required because several tests use named arguments inside LINQ expression trees (a C# 14 feature; net8/net9 default to C# 12/13 which emit CS0853). Verified locally: 69 integration tests pass on each TFM.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #73 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 25 25
Lines 1157 1157
Branches 128 128
=======================================
Hits 1152 1152
Misses 1 1
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--framework net8.0/net9.0build commands tripped onNETSDK1005.Npgsql.EntityFrameworkCore.PostgreSQL8.0.11 / 9.0.4 / 10.0.1) and TFM-conditional code paths. Before this PR, none of those net8/net9 paths were exercised end-to-end. Now they are.CS0853. Pinning<LangVersion>latest</LangVersion>makes the C# 14 compiler available on every TFM. The emitted IL is compatible with net8/net9 runtimes (verified: 69 tests pass on each).Code changes
Equibles.ParadeDB.EntityFrameworkCore.IntegrationTests.csproj:<TargetFramework>net10.0</TargetFramework>→<TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>.<LangVersion>latest</LangVersion>with a one-line comment explaining why.Npgsql.EntityFrameworkCore.PostgreSQL 10.0.1reference with three TFM-conditional<ItemGroup>blocks (8.0.11 / 9.0.4 / 10.0.1), matching the pattern in the main library csproj.