POC: SDL-backed audio path for ncplayer#2906
Open
rebroad wants to merge 23 commits intodankamongmen:masterfrom
Open
POC: SDL-backed audio path for ncplayer#2906rebroad wants to merge 23 commits intodankamongmen:masterfrom
rebroad wants to merge 23 commits intodankamongmen:masterfrom
Conversation
cab01ae to
b8c3fb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Werrorglobally so warnings fail fast, and exportloglevelso helper objects (like the SDL backend) can link against the shared visibility symbolsrc/media/audio-output.[ch]: SDL2 is dlopened on demand, exposes a ring buffer + clock helpers, and is only compiled intoncplayer; CMake now wires inSWRESAMPLEconsistentlyEAGAINwithout dropping audioncplayerto spin a dedicated audio thread, feed the new helpers, throttle logging, and drop video frames when lagging so audio keeps paceStatus
Proof-of-concept. Audio logging still hardcodes
/tmp/ncplayer_audio.log, SDL2 is a runtime dependency forncplayer, and the commits are intentionally chunky for early review. I plan to follow up by gating logging behind env/flags and splitting out the pacing/audio pieces further if this general direction sounds good.Testing
cmake --build build -j$(nproc)on Ubuntu 24.04 (FFmpeg 7.0, SDL 2.28)./build/ncplayer(invocation without args) just to confirm the binary launches with the new audio plumbing