fix: logendx off-by-one in rasterize_core log-end tracking#2919
Open
deths74r wants to merge 1 commit intodankamongmen:masterfrom
Open
fix: logendx off-by-one in rasterize_core log-end tracking#2919deths74r wants to merge 1 commit intodankamongmen:masterfrom
deths74r wants to merge 1 commit intodankamongmen:masterfrom
Conversation
The condition for updating logendy/logendx used strict greater-than for the x comparison: (int)x > nc->rstate.logendx When both logendy and logendx are 0 (cursor at origin), the first rendered cell at (0,0) evaluates as 0 > 0 = false, so the tracking block is never entered. The first character's position is never recorded, causing the post-render cursor to park ON the first character instead of after it. Fix: change > to >= so the first cell at the origin is tracked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The condition for updating
logendy/logendxinrasterize_core()uses strict greater-than for the x comparison:When both
logendyandlogendxare 0 (cursor at origin, as set byNCOPTION_PRESERVE_CURSOR), the first rendered cell at position (0,0) evaluates as0 > 0which is false. The tracking block is never entered, and the first character's position is never recorded inlogendy/logendx.This causes the post-render cursor to park ON the first character instead of after it.
Fix
Change
>to>=so the first cell at the origin is properly tracked.