fix: emit_bg_palindex updates wrong state tracker (lastr -> lastbr)#2920
Open
deths74r wants to merge 1 commit intodankamongmen:masterfrom
Open
fix: emit_bg_palindex updates wrong state tracker (lastr -> lastbr)#2920deths74r wants to merge 1 commit intodankamongmen:masterfrom
deths74r wants to merge 1 commit intodankamongmen:masterfrom
Conversation
emit_bg_palindex() writes the background palette index to nc->rstate.lastr (the foreground palette tracker) instead of nc->rstate.lastbr (the background palette tracker). This corrupts foreground elision state when a palette-indexed background color is emitted, potentially causing incorrect foreground colors on subsequent cells. Fix: change lastr to lastbr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
emit_bg_palindex()writes the background palette index tonc->rstate.lastr(the foreground palette tracker) instead ofnc->rstate.lastbr(the background palette tracker).This corrupts foreground elision state when a palette-indexed background color is emitted, potentially causing incorrect foreground color elision on subsequent cells.
Fix
One-character fix:
lastr→lastbr.For comparison,
emit_fg_palindex()correctly writes tonc->rstate.lastr, and the bg RGB counterpart correctly writes tonc->rstate.lastbr.