Skip to content

DAOS-18882 vos: avoid heap_curr_allocated underflow #18103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grom72 wants to merge 3 commits into from
Closed

DAOS-18882 vos: avoid heap_curr_allocated underflow #18103

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91a8209
DAOS-18882 pmdk: avoid heap_curr_allocated underflow
grom72 Apr 24, 2026
144ea88
recalculate curr_allocated on underflow daos-stack/pmdk#37
osalyk Apr 24, 2026
3d17ab2
Update to pmdk patch list
ryon-jensen Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions utils/build.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,5 @@ ucx=https://github.com/openucx/ucx.git
[patch_versions]
spdk=0001_3428322b812fe31cc3e1d0308a7f5bd4b06b9886.diff,0002_spdk_rwf_nowait.patch,0003_external_isal.patch
mercury=0001_dep_versions.patch,0002_ofi_counters.patch,0003_ofi_auth_key.patch
pmdk=https://github.com/daos-stack/pmdk/commit/69925cf455ef672c4cbdbdb13bef7ae581e67045.diff
Copy link
Copy Markdown
Contributor

@mchaarawi mchaarawi Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, this needs to be:

pmdk=https://github.com/daos-stack/pmdk/commit/bb048d67ccd07609f86a5e8b3c6ad54414d593ee.diff,https://github.com/daos-stack/pmdk/commit/69925cf455ef672c4cbdbdb13bef7ae581e67045.diff

Copy link
Copy Markdown
Contributor

@ryon-jensen ryon-jensen Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the change, but did not test locally.

argobots=0001_411e5b344642ebc82190fd8b125db512e5b449d1.diff,0002_bb0c908abfac4bfe37852eee621930634183c6aa.diff
3 changes: 3 additions & 0 deletions utils/rpms/daos.changelog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
%changelog
* Fri Apr 24 2026 Tomasz Gromadzki <tomasz.gromadzki@intel.com> 2.9.100-3
- Update PMDK to version 2.1.3-2

* Wed Apr 08 2026 Cedric Koch-Hofer <cedric.koch-hofer@hpe.com> 2.9.100-2
- Fix ASAN ODR violation: move src/mgmt/rpc.c into new libdaos_mgmt_crtproto.so
shared library to ensure mgmt_proto_fmt_v3/v4 globals are defined exactly
Expand Down
2 changes: 1 addition & 1 deletion utils/rpms/daos.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

Name: daos
Version: 2.9.100
Release: 2%{?relval}%{?dist}
Release: 3%{?relval}%{?dist}
Summary: DAOS Storage Engine
Copy link
Copy Markdown
Collaborator

@soumagne soumagne Apr 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to bump the DAOS rpm version

Copy link
Copy Markdown
Contributor Author

@grom72 grom72 Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should we do if we want to add information to the daos.changelog but no version has been changed?

Copy link
Copy Markdown
Contributor

@mchaarawi mchaarawi Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well maybe you shouldn't add this to the DAOS changelog?


License: BSD-2-Clause-Patent
Expand Down
2 changes: 1 addition & 1 deletion utils/rpms/package_info.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export argobots_version="1.2"
export argobots_release="4${distro_name}"
export argobots_full="${argobots_version}-${argobots_release}"
export pmdk_version="2.1.3"
export pmdk_release="1${distro_name}"
export pmdk_release="2${distro_name}"
export pmdk_full="${pmdk_version}-${pmdk_release}"
export isal_version="2.31.1"
export isal_release="8${distro_name}"
Expand Down
10 changes: 7 additions & 3 deletions utils/rpms/pmdk.changelog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
%changelog
* Mon Jan 19 2026 Oksana Salyk <oksana.salyk@intel.com> - 2.1.3-1
* Fri Apr 24 2026 Tomasz Gromadzki <tomasz.gromadzki@hpe.com> - 2.1.3-2
- Fix "The pool was not closed" message (no ADR failure) (daos-stack/pmdk#36, DAOS-18692)
- Fix ... (daos-stack/pmdk#37, DAOS-18882, DAOS-12860, DAOS-11978)

* Mon Jan 19 2026 Oksana Salyk <oksana.salyk@hpe.com> - 2.1.3-1
- Expand the sds.at_create CTL to disable unnecessary bad-block checking when running without PMem, preventing the stack overflow (DAOS-18296).
- Fix an issue in the PMEMOBJ allocator with a potential to corrupt the allocator's metadata (DAOS-18195).

* Wed Nov 05 2025 Tomasz Gromadzki <tomasz.gromadzki@intel.com> - 2.1.2-1
* Wed Nov 05 2025 Tomasz Gromadzki <tomasz.gromadzki@hpe.com> - 2.1.2-1
- Expand the sds.at_create CTL to also cover pmemobj_open() (DAOS-17449)
- Previously, this CTL affected only pmemobj_create().
- Now, it affects both pmemobj_create() and pmemobj_open().
Expand All @@ -12,7 +16,7 @@
- Conversely, pmemobj_open() does not issue a warning when attempting to open a pool with SDS disabled
while the feature is force-disabled.

* Fri Oct 31 2025 Tomasz Gromadzki <tomasz.gromadzki@intel.com> - 2.1.0-7
* Fri Oct 31 2025 Tomasz Gromadzki <tomasz.gromadzki@hpe.com> - 2.1.0-7
- Restore the RPM changelog, which has not been available since version 2.1.0-4.

* Fri Sep 12 2025 Jeff Olivier <jeffolivier@google.com> - 2.1.0-6
Expand Down
Loading