Skip to content

obj: recalculate curr_allocated on underflow - 2nd #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janekmi merged 2 commits into from
Apr 27, 2026
+24 −19
Merged

obj: recalculate curr_allocated on underflow - 2nd #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74135ad
obj: recalculate curr_allocated on underflow - 2nd
grom72 Apr 25, 2026
11226cb
use CAS loop in STATS_INC/DEC_persistent
grom72 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 24 additions & 19 deletions src/libpmemobj/stats.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,18 @@ struct stats {
#define STATS_INC_persistent(stats, name, value) do {\
if ((stats)->enabled == POBJ_STATS_ENABLED_PERSISTENT ||\
(stats)->enabled == POBJ_STATS_ENABLED_BOTH) {\
uint64_t curr_value;\
util_atomic_load_explicit64((&(stats)->persistent->name),\
&curr_value, memory_order_acquire);\
if (curr_value != UINT64_MAX) {\
util_fetch_and_add64(\
(&(stats)->persistent->name), (value));\
}\
uint64_t old;\
uint64_t new_val;\
do {\
util_atomic_load_explicit64(\
(&(stats)->persistent->name),\
&old, memory_order_acquire);\
if (old == UINT64_MAX)\
break;\
new_val = (old > UINT64_MAX - (value)) ?\
UINT64_MAX : (old + (value));\
} while (!util_bool_compare_and_swap64(\
(&(stats)->persistent->name), old, new_val));\
}\
} while (0)

Expand All @@ -73,18 +78,18 @@ struct stats {
#define STATS_SUB_persistent(stats, name, value) do {\
if ((stats)->enabled == POBJ_STATS_ENABLED_PERSISTENT ||\
(stats)->enabled == POBJ_STATS_ENABLED_BOTH) {\
uint64_t curr_value;\
util_atomic_load_explicit64((&(stats)->persistent->name),\
&curr_value, memory_order_acquire);\
if (curr_value != UINT64_MAX) {\
curr_value = util_fetch_and_sub64(\
(&(stats)->persistent->name), (value));\
if (curr_value < value || curr_value == UINT64_MAX) {\
util_atomic_store_explicit64(\
(&(stats)->persistent->name),\
UINT64_MAX, memory_order_release);\
}\
}\
uint64_t old;\
uint64_t new_val;\
do {\
util_atomic_load_explicit64(\
(&(stats)->persistent->name),\
&old, memory_order_acquire);\
if (old == UINT64_MAX)\
break;\
new_val = (old < (value)) ?\
UINT64_MAX : (old - (value));\
} while (!util_bool_compare_and_swap64(\
(&(stats)->persistent->name), old, new_val));\
}\
} while (0)

Expand Down
Loading