DAQ: Mask PASSKEY variable coming from HTTP, emitted by Ecowitt - #123
Closed
amotl wants to merge 1 commit into
Closed
DAQ: Mask PASSKEY variable coming from HTTP, emitted by Ecowitt#123amotl wants to merge 1 commit into
PASSKEY variable coming from HTTP, emitted by Ecowitt#123amotl wants to merge 1 commit into
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
==========================================
+ Coverage 52.67% 52.69% +0.02%
==========================================
Files 99 99
Lines 5221 5224 +3
==========================================
+ Hits 2750 2753 +3
Misses 2471 2471
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2 tasks
Member
Author
|
Closing this in favor of GH-125. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
in order to support acquiring data from an Ecowitt device 1, this patch will mask the
PASSKEYvariable from the ingress data. It should not be part of the measurement readings.With kind regards,
Andreas.
Footnotes
https://community.hiveeyes.org/t/ecowitt-wunderground-api-fur-weather-hiveeyes-org-nutzbar/4735 ↩