Grafana: Only permit numeric fields to be established on Graph panels - #126
Merged
Conversation
Other types will make the panel croak like `InfluxDB Error: unsupported mean iterator type: *query.stringInterruptIterator` or `InfluxDB Error: not executed`.
Member
Author
|
A corresponding test case for this issue is part of GH-125. kotori/test/test_device_fineoffset.py Lines 128 to 132 in 1391232 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
when testing GH-125 in production, we discovered at 1 that Grafana would croak on non-numeric fields being established on the Graph panel. They will make the panel croak like
InfluxDB Error: unsupported mean iterator type: *query.stringInterruptIteratororInfluxDB Error: not executed2.While the
ecowitt2mqttdecoder strips all text fields likePASSKEY,stationtype, andmodelfrom the original data, it adds a few other text fields through its computed data:{ "batt1": "OFF", "wh65batt": "OFF", "wh25batt": "OFF", "frostrisk": "No risk", "humidex_perception": "Comfortable", "thermalperception": "Dry" }This patch fixes it, by skipping all non-numeric fields when provisioning the Grafana panel.
With kind regards,
Andreas.
Footnotes
https://climart.hiveeyes.org/grafana/d/climart-testdrive/climart-testdrive ↩
Did anyone of you observe this flaw in the past already, @Tonkenfo, @wetterfrosch, or @ClemensGruber? ↩