feat: support format v4 and bins - #5
Open
upils wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chisel is gaining a new release format (v4) and store-backed packages:
chisel.yamlnow declares
stores:, slice files carrystore:/default-track:, andcontents:paths and
essential:refs accept achannel:filter (canonical/chisel#299,upils/chisel#22, upils/chisel#23). Without support for these, the LSP reports
false errors on any release using them.
Two aspects are worth highlighting. First, a store-backed package is known by a
unique prefixed name (
default-prefix+package:, e.g.curl→bin-curl),and that prefix comes from
chisel.yaml— so the release file is now parsed,watched, and any edit to it re-resolves every package name and re-runs
diagnostics. Second,
channel:is deliberately not used to narrow collisionor redundancy checks: chisel computes path conflicts irrespective of both
channel:andarch:, and matching that stricter behaviour avoids silentlyhiding conflicts that chisel itself rejects.
Note the format also dictates layout: v3 keeps store definitions segregated in
bin-slices/(so older Chisel never reads the new fields), while v4 places themin
slices/; the index follows the declared format and adjusts its watches whenit changes.