chore: start v12.0.0 with SDK updates - #1549
Conversation
…timateShieldedFee moved to manager) - Dashpay.createInvitation no longer returns CreatedInvitation(outPoint, uri) (the gu3 AAR line dropped the outpoint-surfacing blob); the app now recovers the 36-byte funding outpoint from the SDK's persisted invitation row (written before createInvitation returns), matched by the link's assetlocktx txid. Downstream keying/labeling unchanged. - ShieldedProver.estimateFee -> PlatformWalletManager.estimateShieldedFee.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesThe project updates to SDK v42int5, changes wallet version defaults, adapts L1 invitation creation to the new URI response, moves shield fee estimation to the wallet manager, and adds CodeRabbit review configuration. SDK v42int5 integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🔵 Low · up to Invitation funding can complete before the app recovers and displays the resulting voucher, so cancellation followed by a retry could potentially fund a second voucher. The PR is mergeable with explicit owner awareness and follow-up to add durable recovery or idempotency for interrupted funding operations. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…nches CodeRabbit only auto-reviews PRs into the default branch out of the box, so widen auto_review.base_branches to the feat/kotlin-sdk-phase-* line. Also filters build outputs and translations out of reviews, and teaches the reviewer the MVVM/UIState/StateFlow conventions from CLAUDE.md. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Issue being fixed or feature implemented
Related PR's and Dependencies
Screenshots / Videos
How Has This Been Tested?
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Chores