Skip to content

chore: start v12.0.0 with SDK updates - #1549

Open
HashEngineering wants to merge 4 commits into
feat/kotlin-sdk-phase-1from
chore/start-v12.0.0
Open

chore: start v12.0.0 with SDK updates#1549
HashEngineering wants to merge 4 commits into
feat/kotlin-sdk-phase-1from
chore/start-v12.0.0

Conversation

@HashEngineering

@HashEngineering HashEngineering commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

Summary by CodeRabbit

  • New Features

    • Added support for creating L1 invitations using the latest SDK format.
    • Improved recovery of invitation funding details.
  • Bug Fixes

    • Updated shielded balance fee estimation to use the current SDK interface.
  • Chores

    • Updated SDK and wallet version information for the 12.0 release.
    • Added automated code review configuration and Kotlin-specific review guidance.

…timateShieldedFee moved to manager)

- Dashpay.createInvitation no longer returns CreatedInvitation(outPoint, uri)
  (the gu3 AAR line dropped the outpoint-surfacing blob); the app now recovers
  the 36-byte funding outpoint from the SDK's persisted invitation row
  (written before createInvitation returns), matched by the link's
  assetlocktx txid. Downstream keying/labeling unchanged.
- ShieldedProver.estimateFee -> PlatformWalletManager.estimateShieldedFee.
@HashEngineering HashEngineering self-assigned this Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f337009-f17e-491a-94f9-10f33459344e

📥 Commits

Reviewing files that changed from the base of the PR and between 5c8df9d and 2a60273.

📒 Files selected for processing (5)
  • .coderabbit.yaml
  • build.gradle
  • wallet/build.gradle
  • wallet/src/de/schildbach/wallet/service/platform/sdk/SdkL1InviteCreation.kt
  • wallet/src/de/schildbach/wallet/service/platform/sdk/ShieldedBalanceServiceImpl.kt

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Changes

The project updates to SDK v42int5, changes wallet version defaults, adapts L1 invitation creation to the new URI response, moves shield fee estimation to the wallet manager, and adds CodeRabbit review configuration.

SDK v42int5 integration

Layer / File(s) Summary
SDK version and review configuration
.coderabbit.yaml, build.gradle, wallet/build.gradle
The project selects SDK v42int5, updates wallet version defaults to 12.0.0, and adds CodeRabbit review settings and path instructions.
L1 invitation adaptation
wallet/src/de/schildbach/wallet/service/platform/sdk/SdkL1InviteCreation.kt
L1 invitation creation now returns an app-owned carrier with the funding outpoint and bearer URI. The funding outpoint is recovered from the persisted SDK invitation row.
Shield fee API update
wallet/src/de/schildbach/wallet/service/platform/sdk/ShieldedBalanceServiceImpl.kt
Shield fee estimation now uses PlatformWalletManager.estimateShieldedFee.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🔵 Low · up to 2a602

Invitation funding can complete before the app recovers and displays the resulting voucher, so cancellation followed by a retry could potentially fund a second voucher. The PR is mergeable with explicit owner awareness and follow-up to add durable recovery or idempotency for interrupted funding operations.

Suggested reviewers: bfoss765

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (3 skipped: 3… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the two main changes: starting version 12.0.0 and updating the SDK integration.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 2 files. (3 skipped: 3 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/start-v12.0.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…nches

CodeRabbit only auto-reviews PRs into the default branch out of the box,
so widen auto_review.base_branches to the feat/kotlin-sdk-phase-* line.
Also filters build outputs and translations out of reviews, and teaches
the reviewer the MVVM/UIState/StateFlow conventions from CLAUDE.md.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@HashEngineering

Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants