Skip to content

fix: accept hardware input on numeric keypads #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PastaPastaPasta wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: accept hardware input on numeric keypads #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7354a34
fix: support hardware input on numeric keypads
PastaPastaPasta Aug 22, 2026
5d4ef10
refactor: route hardware keypad input through a hidden text field
PastaPastaPasta Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions DashWallet.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,8 @@
750CED612C94BFD7000FB837 /* SettingsMenuViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 750CED5F2C94BFD7000FB837 /* SettingsMenuViewModel.swift */; };
750CEFA12CCA6EA100E87A32 /* TextInput.swift in Sources */ = {isa = PBXBuildFile; fileRef = 750CEFA02CCA6EA100E87A32 /* TextInput.swift */; };
750CEFA22CCA6EA100E87A32 /* TextInput.swift in Sources */ = {isa = PBXBuildFile; fileRef = 750CEFA02CCA6EA100E87A32 /* TextInput.swift */; };
C0DE00010000000000000002 /* HardwareNumericKeyboardView.swift in Sources */ = {isa = PBXBuildFile; fileRef = C0DE00010000000000000001 /* HardwareNumericKeyboardView.swift */; };
C0DE00010000000000000003 /* HardwareNumericKeyboardView.swift in Sources */ = {isa = PBXBuildFile; fileRef = C0DE00010000000000000001 /* HardwareNumericKeyboardView.swift */; };
750CEFA42CCA713300E87A32 /* CreateUsernameViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 750CEFA32CCA712E00E87A32 /* CreateUsernameViewController.swift */; };
7513DA882AB175E0005D55F6 /* TopperViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7527720E2AA9F58E0066557E /* TopperViewModel.swift */; };
7513DA892AB17606005D55F6 /* Topper.swift in Sources */ = {isa = PBXBuildFile; fileRef = 75E2F3C92AA4D1B900C3B458 /* Topper.swift */; };
Expand Down Expand Up @@ -2851,6 +2853,7 @@
750C6CC01B5C8EB60038AAE9 /* el */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = el; path = el.lproj/Localizable.strings; sourceTree = "<group>"; };
750CED5F2C94BFD7000FB837 /* SettingsMenuViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SettingsMenuViewModel.swift; sourceTree = "<group>"; };
750CEFA02CCA6EA100E87A32 /* TextInput.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TextInput.swift; sourceTree = "<group>"; };
C0DE00010000000000000001 /* HardwareNumericKeyboardView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HardwareNumericKeyboardView.swift; sourceTree = "<group>"; };
750CEFA32CCA712E00E87A32 /* CreateUsernameViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CreateUsernameViewController.swift; sourceTree = "<group>"; };
7511E8CB1AE5FF240025F1B3 /* fr */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; lineEnding = 0; name = fr; path = fr.lproj/Localizable.strings; sourceTree = "<group>"; xcLanguageSpecificationIdentifier = xcode.lang.simpleColoring; };
7511E8CF1AE5FF2D0025F1B3 /* ja */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ja; path = ja.lproj/Localizable.strings; sourceTree = "<group>"; };
Expand Down Expand Up @@ -6864,6 +6867,7 @@
isa = PBXGroup;
children = (
51DFA7F72FA8A9DF001EDB3A /* DashStepper.swift */,
C0DE00010000000000000001 /* HardwareNumericKeyboardView.swift */,
516983C02FCAEDD600BA91A2 /* Icons */,
7581B19C2CE3509A00714007 /* Dialogs */,
75EBAA112BB99B6B004488E3 /* BottomSheet.swift */,
Expand Down Expand Up @@ -9747,6 +9751,7 @@
478C983229433C5700FAA0F0 /* PaymentMethodsController.swift in Sources */,
47AE8C1328C5F0A700490F5E /* POIDetailsViewController.swift in Sources */,
750CEFA22CCA6EA100E87A32 /* TextInput.swift in Sources */,
C0DE00010000000000000002 /* HardwareNumericKeyboardView.swift in Sources */,
47AE8C1C28C6AA2500490F5E /* PointOfUseLocationServicePopup.swift in Sources */,
472D13E8299E4EE7006903F1 /* BalanceModel.swift in Sources */,
47F2C6822860319400C2B774 /* TxReclassifyTransactionsInfoViewController.swift in Sources */,
Expand Down Expand Up @@ -10707,6 +10712,7 @@
C9D2C77E2A320AA000D15901 /* ConfirmationTransactionQRController.swift in Sources */,
C9D2C7812A320AA000D15901 /* Numbers+Dash.swift in Sources */,
750CEFA12CCA6EA100E87A32 /* TextInput.swift in Sources */,
C0DE00010000000000000003 /* HardwareNumericKeyboardView.swift in Sources */,
C9D2C7822A320AA000D15901 /* PaymentMethodsController.swift in Sources */,
C9D2C7832A320AA000D15901 /* POIDetailsViewController.swift in Sources */,
C9D2C7842A320AA000D15901 /* PointOfUseLocationServicePopup.swift in Sources */,
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Coinbase/Transfer Amount/TransferAmountView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ struct TransferAmountView<ViewModel: TransferAmountViewModelProtocol>: View {
// MARK: - Keyboard

private var keyboard: some View {
DashUIKit.NumericKeyboardView(
HardwareNumericKeyboardView(
value: Binding(
get: { viewModel.inputValue },
set: { viewModel.setInput($0) }
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/DashPay/Contacts/SwiftUI/ContactProfileSheet.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ struct PayContactSheet: View {
.font(.system(size: 12))
.foregroundColor(.dash.tertiaryText)

NumericKeyboardView(
HardwareNumericKeyboardView(
value: $amountText,
showDecimalSeparator: true,
actionButtonText: NSLocalizedString("Pay", comment: "DashPay Contacts"),
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Explore Dash/Views/DashSpend/Components/DashSpendSinglePanel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ struct DashSpendSinglePanel: View {

Spacer(minLength: 0)

DashUIKit.NumericKeyboardView(
HardwareNumericKeyboardView(
value: $input,
showDecimalSeparator: true,
locale: .autoupdatingCurrent,
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Explore Dash/Views/DashSpend/DashSpendUserAuthScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ struct DashSpendUserAuthScreen: View {

// Bottom section with button or keyboard
if authType == .otp {
DashUIKit.NumericKeyboardView(
HardwareNumericKeyboardView(
value: $viewModel.input,
showDecimalSeparator: false,
locale: .autoupdatingCurrent,
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Menu/Tools/Masternode Withdrawal/EvonodeWithdrawalScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ struct EvonodeWithdrawalScreen: View {
// MARK: Keyboard

private var keyboardSection: some View {
NumericKeyboardView(
HardwareNumericKeyboardView(
value: keypadBinding,
showDecimalSeparator: true,
actionButtonText: NSLocalizedString("Continue", comment: ""),
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Payments/Amount/SendAmountScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ private struct SendAmountKeyboardSection: View {

var body: some View {
VStack(spacing: 0) {
DashUIKit.NumericKeyboardView(
HardwareNumericKeyboardView(
value: $value,
showDecimalSeparator: true,
locale: locale,
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Payments/Amount/SpecifyAmountViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ private struct SpecifyAmountView: View {

Spacer(minLength: 0)

DashUIKit.NumericKeyboardView(
HardwareNumericKeyboardView(
value: Binding(
get: { model.currentInputString },
set: { model.updateKeyboardInputString($0) }
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Payments/InternalTransfer/InternalTransferScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ struct InternalTransferScreen: View {
// MARK: - Keyboard

private var keyboardSection: some View {
NumericKeyboardView(
HardwareNumericKeyboardView(
value: keypadBinding,
showDecimalSeparator: true,
actionButtonText: NSLocalizedString("Continue", comment: ""),
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Payments/Pay/SendScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ struct ExternalSendAmountScreen: View {
// MARK: - Keyboard

private var keyboardSection: some View {
NumericKeyboardView(
HardwareNumericKeyboardView(
value: keypadBinding,
showDecimalSeparator: true,
actionButtonText: NSLocalizedString("Continue", comment: ""),
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Swap/Buy/EnterAmount/BuyEnterAmountView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ struct BuyEnterAmountView: View {
// MARK: - Keyboard

private var keyboard: some View {
NumericKeyboardView(
HardwareNumericKeyboardView(
value: Binding(
get: { viewModel.inputValue },
set: { viewModel.setInput($0) }
Expand Down
2 changes: 1 addition & 1 deletion DashWallet/Sources/UI/Swap/Convert/SwapConvertView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ struct SwapConvertView: View {
// MARK: - Keyboard

private var keyboard: some View {
NumericKeyboardView(
HardwareNumericKeyboardView(
value: Binding(
get: { viewModel.inputValue },
set: { viewModel.setInput($0) }
Expand Down
Loading
Loading