-
Notifications
You must be signed in to change notification settings - Fork 24
refactor(ui): consolidate bottom sheets on DashUIKit #1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PastaPastaPasta
wants to merge
4
commits into
develop
Choose a base branch
from
refactor/dashuikit-bottom-sheet-foundation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b5c6790
refactor(explore): use DashUIKit for marketplace sheets
PastaPastaPasta 8d2b8a9
refactor(ui): consolidate bottom sheets on DashUIKit
PastaPastaPasta da64754
refactor(ui): remove legacy sheet measurement
PastaPastaPasta ab56618
fix(ui): preserve marketplace sheet layouts
PastaPastaPasta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -99,7 +99,7 @@ private struct SwapFeeInfoSheetPreviewHost: View { | |
| Color.dash.primaryBackground | ||
| .ignoresSafeArea() | ||
| .sheet(isPresented: $isPresented) { | ||
| // let sheet = BottomSheet(showBackButton: .constant(false)) { | ||
| // let sheet = DashUIKit.BottomSheet(showBackButton: .constant(false)) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: this eight-line commented-out block was updated to the new name rather than deleted. Keeping dead code in sync with live code is pure carrying cost — it should go. |
||
| // SwapFeeInfoSheet(onDismiss: {}) | ||
| // } | ||
| // | ||
|
|
@@ -109,7 +109,7 @@ private struct SwapFeeInfoSheetPreviewHost: View { | |
| // sheet | ||
| // } | ||
|
|
||
| BottomSheet(showBackButton: .constant(false), fillsHeight: false) { | ||
| DashUIKit.BottomSheet(showBackButton: .constant(false), fillsHeight: false) { | ||
| SwapFeeInfoSheet(usesGenericFeeInfo: false, onDismiss: {}) | ||
| } | ||
| .selfSizingSheet() | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging here as representative of all ~15 migrated sheets: the grabber changes colour app-wide.
The deleted local
BottomSheetdrew it withColor.dash.gray300Alpha50—#B0B5BDat 50% alpha, with no dark-mode variant.DashUIKit.BottomSheetusesColor.dash.grabberFill—#B0B6BCat 100% alpha in light mode, white at 30% in dark.So in light mode the grabber becomes twice as opaque on every bottom sheet in the app, and dark mode gains a variant it didn't have. This looks intentional (it aligns everything with
DashSpendConfirmationDialog, which already usedgrabberFill), but the PR body says "Breaking Changes: None" and "preserved each migrated caller's existing … behavior", and there is no UI CI here — onlyValidate PR titleand CodeRabbit ran. Two sheets are screenshotted; the change lands on all of them. Worth naming in the description and confirming with design.