chore: define per-crate code owners #4449
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,61 @@ | ||
| # Code owners for dashpay/platform. | ||
| # | ||
| # Rules are last-match-wins: the final matching line decides ownership. | ||
| # Only ONE owner's approval is needed per changed path (branch protection | ||
| # requires 1 approving review from a code owner). | ||
| # | ||
| # Team membership is the knob to turn when review load shifts — prefer | ||
| # adding someone to a team over editing this file. | ||
|
|
||
| # Fallback for anything not matched below. | ||
| * @shumkov @lklimek | ||
|
|
||
| # ---------- Consensus core ---------- | ||
| /packages/rs-drive-abci/ @dashpay/drive-owners | ||
| /packages/rs-drive/ @dashpay/drive-owners | ||
| /packages/rs-dpp/ @dashpay/drive-owners | ||
| /packages/rs-platform-version/ @dashpay/drive-owners | ||
| /packages/rs-platform-value/ @QuantumExplorer | ||
| /packages/rs-drive-proof-verifier/ @dashpay/drive-owners @lklimek | ||
|
|
||
| # ---------- DAPI / wire ---------- | ||
| /packages/rs-dapi/ @dashpay/sdk-owners | ||
| /packages/rs-dapi-client/ @dashpay/sdk-owners | ||
| /packages/dapi-grpc/protos/ @dashpay/sdk-owners | ||
|
|
||
| # ---------- Rust SDK / WASM ---------- | ||
| /packages/rs-sdk/ @dashpay/sdk-owners | ||
| /packages/rs-sdk-ffi/ @dashpay/sdk-owners @ZocoLini | ||
| /packages/rs-sdk-trusted-context-provider/ @dashpay/sdk-owners | ||
| /packages/dash-platform-queries/ @dashpay/sdk-owners | ||
| /packages/wasm-sdk/ @dashpay/sdk-owners | ||
| /packages/wasm-dpp/ @dashpay/sdk-owners | ||
| /packages/wasm-dpp2/ @dashpay/sdk-owners | ||
| /packages/wasm-drive-verify/ @dashpay/sdk-owners | ||
|
|
||
| # ---------- Wallet stack ---------- | ||
| /packages/rs-platform-wallet/ @dashpay/wallet-owners | ||
| /packages/rs-platform-wallet-ffi/ @dashpay/wallet-owners | ||
| /packages/rs-platform-wallet-storage/ @dashpay/wallet-owners | ||
|
|
||
| # ---------- Mobile ---------- | ||
| /packages/swift-sdk/ @dashpay/mobile-team | ||
| /packages/kotlin-sdk/ @dashpay/mobile-team | ||
| /packages/rs-unified-sdk-jni/ @dashpay/mobile-team | ||
|
|
||
| # ---------- JavaScript / Node ---------- | ||
| /packages/dashmate/ @dashpay/js-owners | ||
| /packages/dapi/ @dashpay/js-owners | ||
| /packages/js-dapi-client/ @dashpay/js-owners | ||
| /packages/js-evo-sdk/ @dashpay/js-owners | ||
| /packages/js-dash-sdk/ @dashpay/js-owners | ||
| /packages/wallet-lib/ @dashpay/js-owners | ||
| /packages/dash-spv/ @dashpay/js-owners | ||
| /packages/platform-test-suite/ @dashpay/js-owners | ||
| /packages/js-grpc-common/ @dashpay/js-owners | ||
| /packages/bench-suite/ @dashpay/js-owners | ||
|
Comment on lines
+18
to
+56
Collaborator
There was a problem hiding this comment. 🔴 Blocking: Ensure every substantial ownership group has at least two approvers Two explicit ownership assignments still preserve the single-person bottleneck this PR is intended to remove. Line 18 overrides the two-person fallback for source: ['codex'] |
||
|
|
||
| # ---------- Build & CI ---------- | ||
| /.github/workflows/ @dashpay/infra-team @shumkov | ||
| /Cargo.toml @dashpay/drive-owners | ||
| /CODEOWNERS @QuantumExplorer @shumkov | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Blocking: Provision the referenced teams before merging
At head
5bd8e28825e33764378de99d8d903f22c1b584e0, GitHub'srepos/dashpay/platform/codeowners/errorsendpoint reports 34Unknown ownererrors. Every reference to@dashpay/drive-owners,@dashpay/sdk-owners,@dashpay/wallet-owners,@dashpay/mobile-team,@dashpay/js-owners, and@dashpay/infra-teamis currently invalid because GitHub cannot resolve the team with the required visibility and repository write access. This prevents the new team-based rules from routing reviews as intended across lines 14-17, 19, 22-24, 27-34, 37-44, 47-56, 59, and 60. Create or grant access to the teams, then verify that the endpoint returns no errors before merging.source: ['codex']