Improve cbs executor atomicity by using a single transaction - #2944
Open
tkalir wants to merge 7 commits into
Open
Improve cbs executor atomicity by using a single transaction#2944tkalir wants to merge 7 commits into
tkalir wants to merge 7 commits into
Conversation
tkalir
force-pushed
the
new-cbs-format-fix-cbs-import-atomicity
branch
3 times, most recently
from
August 4, 2026 19:00
c94280e to
ce53ec9
Compare
tkalir
force-pushed
the
new-cbs-format-fix-cbs-import-atomicity
branch
from
August 13, 2026 18:22
5bb8f44 to
c291adb
Compare
Collaborator
Author
|
Hi @ziv17, This PR puts the entire CBS import flow, including the safety-data import, under a single transaction. I changed the safety-data flow so that it can use the existing session when called as part of the CBS pipeline, while retaining its standalone behavior by creating its own session and transaction when called separately. I also added an integration test that forces a failure before the final commit and verifies that relevant tables haven't changed. I’d appreciate any feedback, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.