Draft
Fix Tests workflow regressions from safety-data junction schema changes#2947
Conversation
Co-authored-by: ziv17 <28224696+ziv17@users.noreply.github.com>
Co-authored-by: ziv17 <28224696+ziv17@users.noreply.github.com>
Co-authored-by: ziv17 <28224696+ziv17@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job Tests
Fix Tests workflow regressions from safety-data junction schema changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TestsGitHub Actions job was failing after safety-data schema changes removednon_urban_intersectionfrom marker views while related widget filtering still depended on it. The same branch also left a few tests pinned to pre-migration severity IDs and vehicle mappings.Junction filtering
non_urban_intersectionwhen present,intersection,false()when the view has no junction field or the segment has no mapped junctions.Severity filter compatibility
InjurySeverity.codes().Targeted test updates
AccidentSeverityvalues.intersectionfallback and thefalse()behavior when junction expansion is unavailable.