Skip to content

Upload schools report notebook outputs to non-production S3 path - #2954

Merged
tkalir merged 1 commit into
data-for-change:new-cbs-formatfrom
tkalir:2851-schools-report-2025-on-new-cbs-format
Aug 17, 2026
Merged

Upload schools report notebook outputs to non-production S3 path#2954
tkalir merged 1 commit into
data-for-change:new-cbs-formatfrom
tkalir:2851-schools-report-2025-on-new-cbs-format

Conversation

@tkalir

@tkalir tkalir commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Run the notebook S3 cells and confirm objects appear under schools_report/output_2025
  • Confirm no writes to schools_report/output
  • Confirm generated *.csv files from schools_results are uploaded to the same prefix

Write JSON and generated CSVs to schools_report/output_2025 so production schools_report/output is left unchanged.
@tkalir
tkalir merged commit 5f7edbc into data-for-change:new-cbs-format Aug 17, 2026
3 checks passed
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.82%. Comparing base (3fe50a2) to head (5b7366d).
⚠️ Report is 3 commits behind head on new-cbs-format.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           new-cbs-format    #2954   +/-   ##
===============================================
  Coverage           47.82%   47.82%           
===============================================
  Files                 129      129           
  Lines               11878    11878           
===============================================
  Hits                 5681     5681           
  Misses               6197     6197           
Flag Coverage Δ
unittests 47.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants