Convert OHDSI PLP sql to duckdb format#19
Merged
Conversation
…s that are not supported by duckdb. So, we need to convert them into appropriate format. This commit translates DDL statements (CREATE TABLE) and other column data-types into appropriate duckdb versions.
csafreen
approved these changes
Apr 16, 2026
SantanM
reviewed
Apr 16, 2026
Comment on lines
+166
to
+184
| if (grepl("\\bint\\b", statement, ignore.case = TRUE)) { | ||
| translation_done <- TRUE | ||
| statement <- gsub("\\bint\\b", "INTEGER", statement, ignore.case = TRUE) | ||
| } | ||
|
|
||
| if (grepl("VARCHAR\\s*\\(\\s*MAX\\s*\\)", statement, ignore.case = TRUE)) { | ||
| translation_done <- TRUE | ||
| statement <- gsub("VARCHAR\\s*\\(\\s*MAX\\s*\\)", "VARCHAR", statement, ignore.case = TRUE) | ||
| } | ||
|
|
||
| if (grepl("\\btext\\b", statement, ignore.case = TRUE)) { | ||
| translation_done <- TRUE | ||
| statement <- gsub("\\btext\\b", "TEXT", statement, ignore.case = TRUE) | ||
| } | ||
|
|
||
| if (grepl("\\bfloat\\b", statement, ignore.case = TRUE)) { | ||
| translation_done <- TRUE | ||
| statement <- gsub("\\bfloat\\b", "DOUBLE", statement, ignore.case = TRUE) | ||
| } |
Contributor
There was a problem hiding this comment.
These conversions are handled by the default rules of duckdb dialect. It is not necessary to add them again here. I suggest to remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OHDSI PLP (PatientLevelPrediction) package creates some SQL statements that are not supported by duckdb. So, we need to convert them into appropriate format.
This commit translates DDL statements (CREATE TABLE) and other column data-types into appropriate duckdb versions.