Add functionality to write to a temp file through url arguments#5
Merged
kahing merged 6 commits intodatabricks:mainfrom Aug 25, 2021
Merged
Add functionality to write to a temp file through url arguments#5kahing merged 6 commits intodatabricks:mainfrom
kahing merged 6 commits intodatabricks:mainfrom
Conversation
kahing
approved these changes
Aug 18, 2021
kahing
pushed a commit
that referenced
this pull request
Aug 26, 2021
kahing
pushed a commit
that referenced
this pull request
Aug 26, 2021
kahing
pushed a commit
that referenced
this pull request
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is similar to the existing option that allows url arguments to be passed in as command line arguments. Instead, we create a temporary file in /tmp/ and write the url arguments to this file, separated by newlines. The temporary file name is then passed to the command as a command line argument.
Because of this behaviour, the command line args option and the temporary file option should be mutually exclusive.
We can then use this to pass secret values to the running process as command line arguments are easily visible through process status.
public PR: tsl0922/ttyd#747