fix normalieze manifests issue#585
Merged
Merged
Conversation
Signed-off-by: yxxhero <aiopsclub@163.com>
…ests-issue # Conflicts: # manifest/parse.go # manifest/parse_test.go
- Rename ContentNormalizeManifests to unexported normalizeContent (avoids widening the public API; name avoids clash with the normalizeManifests bool parameter) - Move the test into an internal package (manifest) to access the unexported helper - Add an error-path case (sequence cannot unmarshal into map) - Use require.NoError/require.Error and direct []byte comparison Signed-off-by: yxxhero <aiopsclub@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
manifest/parse.goandmanifest/parse_test.gofiles to improve the normalization of YAML content and add corresponding tests.Improvements to YAML normalization:
manifest/parse.go: Refactored the normalization logic into a new functionContentNormalizeManifeststo enhance code readability and maintainability. [1] [2]Testing enhancements:
manifest/parse_test.go: Added a new test functionTestContentNormalizeManifeststo ensure theContentNormalizeManifestsfunction works correctly with various input scenarios.