Cannot cluster as instructed because sciNames gone#327
Open
jas58 wants to merge 2 commits intodatacarpentry:mainfrom
Open
Cannot cluster as instructed because sciNames gone#327jas58 wants to merge 2 commits intodatacarpentry:mainfrom
jas58 wants to merge 2 commits intodatacarpentry:mainfrom
Conversation
This episode. Oof. This episode already split scientificNames into two separate columns after trimming white space. Are we supposed to remember to have unchecked the box to delete the original column in the first set of instructions? I can go add that command instead. Learners cannot cluster on two columns. Or should the instructions focus on just species? That would be a few replacements of scientificName with species and a few edits to the demo text. Suggestions welcome.
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
The step was lost and is very important by the end of the episode.
jas58
commented
May 19, 2025
Author
jas58
left a comment
jas58
left a comment
There was a problem hiding this comment.
Feeling much better about the "keep original" column checkbox being noticeable now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This episode already split scientificNames into two separate columns after trimming white space. Are we supposed to remember to have unchecked the box to delete the original column in the first set of instructions? I can go add that command instead. Learners cannot cluster on two columns. Or should the instructions focus on just species? That would be a few replacements of scientificName with species and a few edits to the demo text. Suggestions welcome.
I'm added emphasis around "Important!" in the first set of directions for bold.