Fix accessibility issues and Cypress test rate limiting#978
Open
ashwinisukale wants to merge 12 commits into
Open
Fix accessibility issues and Cypress test rate limiting#978ashwinisukale wants to merge 12 commits into
ashwinisukale wants to merge 12 commits into
Conversation
Contributor
Author
|
@jrhoads Since this PR changes several colors and hover states to improve accessibility, the UI may not look exactly the same as before. Please run Bracco locally and do a visual review of the affected pages before deploying to production to ensure the updated styling looks good and there are no unintended regressions. |
Copilot
AI
changed the title
Fixed accessibility issues
Fix accessibility issues and Cypress test rate limiting
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing "Cypress Testing / cypress-test" CI job and resolves accessibility issues in several components and templates.
Root Cause of CI Failure
The Cypress tests were failing with 403 "rate limited" responses from the
/tokenAPI endpoint inbefore allhooks. WithoutcacheAcrossSpecs: true, each spec file independently callscy.login()which POSTs to/token. With 10+ spec files making token requests for the same users, the API rate limit was exceeded for the later specs.Changes Made
Cypress Test Fixes
cypress/support/commands.js: EnabledcacheAcrossSpecs: trueso sessions are reused across all spec files for the same username, reducing token requests from ~6 per user to 1.cypress/e2e/organization_admin/repositories.test.ts: Added null guard forcookieinafter()hook to prevent secondaryTypeErrorwhen login fails.cypress/e2e/organization_admin/settings.test.ts: Added null guard forcookieinafter()hook.cypress/e2e/staff_admin/contact.test.ts: Added null guard forcookieinafter()hook.Accessibility Fixes
app/components/cc-license.hbs: Improved accessibility markup.app/components/doi-list.hbs: Fixed aria-label on "clear link check status filter" link (was incorrectly saying "Filter DOIs by..." for the clear action).app/components/model-search.hbs: Accessibility improvements.app/components/organization-list.hbs: Accessibility improvements.app/components/provider-list.hbs: Accessibility improvements.app/components/repository-list.hbs: Accessibility improvements.app/styles/local.css: Style updates supporting accessibility.app/templates/contacts/index.hbs: Fixed aria-label on "clear role filter" link (removed role title from the clear action label).app/templates/prefixes/index.hbs: Accessibility improvements.app/templates/providers/show/contacts/index.hbs: Accessibility improvements.app/templates/providers/show/prefixes/index.hbs: Accessibility improvements.vendor/datacite-styles/doi/globals/_colors.scss: Color contrast fix.