Fix RAVV thread-local supplier leaks#662
Draft
Trihedron1240 wants to merge 1 commit intodatastax:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RandomAccessVectorValuesthread-local supplier cleanup by exposing a closeable supplier path.ExplicitThreadLocal, including copies created during graph build and quantization flows.GraphIndexBuilderreleases copied vector values.Closes #635
Root Cause
RandomAccessVectorValues.threadLocalSupplier()usedExplicitThreadLocalinternally but returned onlytl::get, so callers had no way to close the thread-local container or the copied vector values it owned. This leaked closeable copies created for shared RAVV implementations.Validation
git diff --check origin/main...HEADmvn -B verifyusing local JDK 25mvn -B -Pjdk20 -am -pl jvector-tests testusing local JDK 25mvn -B -Pjdk11 -am -pl jvector-tests testusing local JDK 25Notes
The GitHub Actions AVX/native lanes and manual benchmark workflow should still be reviewed on GitHub runner hardware.