Skip to content

feat(suggest): disable autocomplete #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jolg42 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(suggest): disable autocomplete #1208

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c15a2d7
feat(suggest) disable autocomplete
Jolg42 Oct 21, 2025
b8edaf8
formatting for CI check
Jolg42 Oct 21, 2025
df13b7a
Update src/suggest-edit.js
Jolg42 Oct 23, 2025
4bbf242
squash me: set attr on inputs, source comments
baltpeter Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/suggest-edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,28 @@ function renderForm(schema, company_data = undefined) {
}
}
});

// Create and render form
bf = BrutusinForms.create(schema);
bf.render(
document.getElementById('suggest-form'),
company_data || (PARAMETERS['name'] ? { name: PARAMETERS['name'] } : {})
);

// Set attributes to avoid autocompletion on the form
// This is to avoid private data to be submitted (e.g. via a Password Manager)
document.querySelectorAll('form.brutusin-form input, form.brutusin-form textarea').forEach((el) => {
el.setAttribute('autocomplete', 'off');
// https://developer.1password.com/docs/web/compatible-website-design/#ignore-offers-to-save-or-fill-specific-fields
el.setAttribute('data-1p-ignore', '');
// https://support.lastpass.com/s/document-item?language=en_US&bundleId=lastpass&topicId=LastPass%2Fc_lp_prevent_fields_from_being_filled_automatically.html&_LANG=enus
el.setAttribute('data-lpignore', 'true');
// https://stackoverflow.com/a/51272839
el.setAttribute('data-protonpass-ignore', 'true');
// https://github.com/bitwarden/clients/blob/e1415af407fef139fb69126349e5cc6d286f4474/apps/browser/src/autofill/services/collect-autofill-content.service.ts#L884-L889
el.setAttribute('data-bwignore', 'true');
});

suggestSimilarNamedCompanies();
}

Expand Down