Skip to content

Fixes dependency version for brutusin-json-forms to specific commit hash #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baltpeter merged 1 commit into from
Oct 22, 2025
Merged

Fixes dependency version for brutusin-json-forms to specific commit hash #1209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
},
"dependencies": {
"autocomplete.js": "^0.37.0",
"brutusin-json-forms": "https://github.com/brutusin/json-forms",
"brutusin-json-forms": "https://github.com/brutusin/json-forms#44f27b29ef657f545b8a3d162c2b9c90ef137dbc",
"cross-dirname": "^0.1.0",
"deepmerge": "^4.2.2",
"fast-deep-equal": "^3.1.3",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3112,7 +3112,7 @@ browserslist@^4.20.2:
node-releases "^2.0.3"
picocolors "^1.0.0"

"brutusin-json-forms@https://github.com/brutusin/json-forms":
"brutusin-json-forms@https://github.com/brutusin/json-forms#44f27b29ef657f545b8a3d162c2b9c90ef137dbc":
version "0.0.0"
resolved "https://github.com/brutusin/json-forms#44f27b29ef657f545b8a3d162c2b9c90ef137dbc"
Copy link
Copy Markdown
Member

@mal-tee mal-tee Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! But doesn't the resolved entry already pin the version? :)

Copy link
Copy Markdown
Contributor Author

@Jolg42 Jolg42 Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed, but it makes the dependency requirement clearer directly in package.json
To take an example with any other package, no package is set with "mypackage": "latest" in the package.json (though they are pinned in the lockfile).
Here the same logic applies.


Expand Down