Skip to content

initial draft of reworked selection menu#1244

Draft
mal-tee wants to merge 1 commit intomasterfrom
m_mrq_selection_m
Draft

initial draft of reworked selection menu#1244
mal-tee wants to merge 1 commit intomasterfrom
m_mrq_selection_m

Conversation

@mal-tee
Copy link
Copy Markdown
Member

@mal-tee mal-tee commented Dec 25, 2025

What do you think of a reworked selection menu for my-request? I propose something like this:

NEW:
image

OLD:
image

TODO:

  • the buttons are not perfectly centered, the padding at the right is bigger
  • is there a smarter way to include HTML elements like spans into translated strings? the fields of the <Text> elements do not render elements
  • i18n-ify new strings
  • deprecate old strings

@mal-tee mal-tee marked this pull request as draft December 25, 2025 18:31
@cypress
Copy link
Copy Markdown

cypress bot commented Dec 25, 2025

@baltpeter
Copy link
Copy Markdown
Member

is there a smarter way to include HTML elements like spans into translated strings? the fields of the <Text> elements do not render elements

If it isn't too complex, you can put the HTML into the translation files and use <MarkupText> instead of <Text>.

@baltpeter
Copy link
Copy Markdown
Member

Thanks for having a go at this! I agree that we should try to tidy this up and make it more… scannable and I like your idea. However, I think it's a little unconventional, unfortunately. Afaik, this doesn't exist as a UX pattern anywhere else and might end up being more confusing to users. Plus, the labels ("Selection CSV export", "Selection mark as done") unfortunately just don't work for this. I am also worried about accessibility. I don't see how we could assign the "Selection…" label with the other buttons.

I don't have the solution myself, either. But considering your draft gave me a few ideas and thoughts:

  • This reminded me of window menus, which can be hierarchical/nested and might have a Selected menu that then has all the other things as sub menus. I think this would be much more conventional and familiar to users. We don't currently have nested menus but I don't think we need them, either.

    I think the main issue here currently is that icon-ellipsis already denotes a selection menu (i.e. one, where all actions apply to the selected items) but we're not using it correctly. We also have one unrelated action ("Deselect all") in there. Just moving that outside of the dropdown would already be a major improvement imo.

  • If we do that, we don't need the <hr> you introduced to distinguish between stuff that belongs in the menu and stuff that doesn't anymore, but can instead use it for some logical grouping of related actions. That should break up the actions nicely and make it easier to find the one you're looking for.

  • I am not sure whether shortening the labels is a good idea. This absolutely makes them more scannable, but I do think it comes with quite a significant loss of clarity.

  • The inline pills are pretty cool. I was recently reminded of old Apple HIGs and this is very reminiscent of that. :D

    My instinct would be to style the full button (like you did with "delete") instead, which I think is a lot more common these days. But I'm not sure. Maybe your approach is better in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants