My Requests: Toggle selection mode with keybinds

[mal-tee]

No description provided.

[cypress]

datenanfragen/website    Run #8834

Run Properties:   Passed #8834  •  47f98b6a9a: My Requests: Toggle selection mode with keybinds

Project	datenanfragen/website
Branch Review	m_myr_sel_keybind
Run status	Passed #8834
Run duration	04m 36s
Commit	47f98b6a9a: My Requests: Toggle selection mode with keybinds
Committer	Malte
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	2
Pending	8
Skipped	0
Passing	84
View all changes introduced in this branch ↗︎

[baltpeter]

Thank you!

I did notice a few quite major regressions, the keyhandler is currently very overzealous:

• Text entry (e.g. when adding a new message to a proceeding) is completely broken. When you press Shift (in the modal, to capitalize a letter), selection mode is toggled, the event gets swallowed, and focus to the text element is lost.
• Selection mode toggles even when Ctrl is pressed in combination with other keys, e.g. when copying text with Ctrl + C.

Besides that, merely toggling selection mode with Ctrl/Shift also feels a bit unnatural to me, I'm not sure whether that's a pattern anywhere else. Typically (e.g. in a file browser), I'd say, Ctrl/Shift only has an effect while it is held: While you're holding Ctrl/Shift, you can multi-select files by clicking on them, but as soon as you let go, you're back in normal (single-select) mode.

I'm not sure what the best way to implement keybindings here is, either, but an idea that is more similar to what I described and that we could try is:

• In keydown, turn selection mode on.
• In keyup, if the selection is empty, turn selection mode off, otherwise leave it on.

We might even want to let the user select proceedings by clicking on their row (instead of the checkbox) while they key is pressed to mimic file browser behaviour.

But one thing that might make this a bad idea: Holding Shift and clicking already has browser behaviour (text selection) that interferes with our selection…

[mal-tee]

Thank you for the feedback! Superseeded by #1255