Skip to content

WIP: Port /suggest to formj#1268

Draft
mal-tee wants to merge 42 commits intowebpack-node-stagingfrom
m_formj
Draft

WIP: Port /suggest to formj#1268
mal-tee wants to merge 42 commits intowebpack-node-stagingfrom
m_formj

Conversation

@mal-tee
Copy link
Copy Markdown
Member

@mal-tee mal-tee commented Apr 13, 2026

No description provided.

baltpeter and others added 30 commits March 30, 2026 21:24
* Update to Hugo v0.140.0

This release brings various useful new esbuild features.

* Migrate JS bundles from Webpack to Hugo esbuild

* properly set NODE_ENV, fix PDF worker bundle URL

* code splitting using js.Batch

* wait for HTTP instead of TCP

* replace webpack-i18n-loader

* mostly use defines instead of generating scripts using Hugo templates

* Webpack be gone \o/

* Fixes #871: Remove `requests` scope from `I18N_DEFINITION`

* build-i18n: EN may affect translations for other langs

* address review

* build-i18n: unlink and fix allTranslations bug
Currently translated at 100.0% (1078 of 1078 strings)

Translation: Datenanfragen.de/website
Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/hr/

Co-authored-by: Milo Ivir <mail@milotype.de>
Currently translated at 100.0% (1078 of 1078 strings)

Translation: Datenanfragen.de/website
Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/hr/

Co-authored-by: Milo Ivir <mail@milotype.de>
I deliberately didn't change the sort order for the exports (CSV and
ICS). I think for those, old to new makes more sense.

I've added a prop to RequestList to determine the sort order. In the
future, we might want to add a UI toggle for that. But this order seems
much more sensible to me.
* Tests: Env var for configuring retries

* Re #1232: Disable tests that always fail in production
* Fixes #983: 'Delete selected proceedings' button for 'My requests'

* Fixes #985: Bulk actions for proceeding status in 'My requests'

* Fixes #984: Let users mark requests as abandoned

* Fixes #1023: Allow webform in more places using TransportMediumChooser

* Fixes #1225: Link to company pages in 'My requests'
These should hopefully make it less likely for people to mistake our
contribution avenues for contact forms…

via: https://simonwillison.net/2025/Aug/2/wikipedia-save-button/
The modals pops up after disabling certain features. It asks if data should be deleted.
The previous negative option was "cancel". Imo this implies that hitting cancel re-enables
the option.

Additionally, "no" is the correct answer to a question whereas "cancel" is not.
* Translated using Weblate (Croatian)

Currently translated at 100.0% (1079 of 1079 strings)

Translation: Datenanfragen.de/website
Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/hr/

* Translated using Weblate (Spanish)

Currently translated at 96.1% (1044 of 1086 strings)

Translation: Datenanfragen.de/website
Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/es/

---------

Co-authored-by: Milo Ivir <mail@milotype.de>
Currently translated at 68.8% (748 of 1086 strings)

Translation: Datenanfragen.de/website
Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/nl/
Currently translated at 68.9% (749 of 1086 strings)

Translation: Datenanfragen.de/website
Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/nl/
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.17.23)

---
updated-dependencies:
- dependency-name: lodash
  dependency-version: 4.17.23
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The minimal implementation we used previously for example could not
deal with non-ASCII characters and would for example turn umlauts into
slashes, which is easy to miss when reviewing.

With this commit, we now use @sindresorhus/slugify with `decamelize`
disabled, which matches data-editor.
)

There have been no material changes to the sections we reference, only
minor wording changes that don't invalidate our conclusions, and some
new paras have been introduced, which caused shifts.

Note how there is an English version 2.1, while the (new) German
version is only available as 2.0. According to the version history
in the English PDF, version 2.1 only had "Minor corrections".
There has been further consolidation of the German public broadcaster
SVAs. As per the 2025 report of the (former) NDR SVA
(https://datenschutzarchiv.org/fileadmin/Dokumente/2025/TB_NDR_2025_de.pdf,
via: https://artikel91.eu/2026/02/13/aufsicht-am-ende-wochenrueckblick-kw-7-2026/#Weniger_spezifische_Aufsichten),
it has been dissolved and "Der Rundfunkdatenschutzbeauftragte"
(renamed yet again) is now also responsible for NDR.

In fact, they are now _also_ responsible for Radio Bremen (that SVA
has also been dissolved) and the Beitragsservice (where the SVA role
was previously split between the Rundfunkdatenschutzbeauftragte, the
NDR SVA, as well as a few state SVAs.

The Rundfunkdatenschutzbeauftragte has the following news entry from
2025-12-01 (https://www.mdr.de/rundfunkdatenschutz/index.html):

> Am 1. Dezember 2025 ist der durch den siebten
> Medienänderungsstaatsvertrag geänderte Medienstaatsvertrag (MStV) in
> Kraft getreten. Die §§ 31j ff. MStV legen nunmehr Stellung, Aufgaben
> und Befugnisse des gemeinsamen Rundfunkdatenschutzbeauftragten fest.
> Der Rundfunkdatenschutzbeauftragte ist durch gesetzliche Zuweisung
> zuständige Aufsichtsbehörde für alle in der ARD zusammengeschlossenen
> Landesrundfunkanstalten, das ZDF und Deutschlandradio sowie ihre
> Beteiligungsunternehmen.

Their "Tasks" page now confirms that they are responsible for NDR and
Radio Bremen:
https://www.mdr.de/rundfunkdatenschutz/ueber-uns/aufgaben/aufgaben-100.html

And the Beitragsservice confirms that the
Rundfunkdatenschutzbeauftragte is now responsible for them:
https://www.rundfunkbeitrag.de/datenschutz/datenschutzrechtliche-aufsichtsbehoerde
* Update security.txt: Add Bug-Bounty: False

via https://lists.haxx.se/pipermail/daniel/2026-March/000148.html

* sign

---------

Co-authored-by: Benjamin Altpeter <hi@bn.al>
dependabot bot and others added 12 commits April 11, 2026 16:18
Bumps [flatted](https://github.com/WebReflection/flatted) from 3.2.4 to 3.4.2.
- [Commits](WebReflection/flatted@v3.2.4...v3.4.2)

---
updated-dependencies:
- dependency-name: flatted
  dependency-version: 3.4.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [carbone](https://carbone.io) from 3.2.3 to 3.5.6.

---
updated-dependencies:
- dependency-name: carbone
  dependency-version: 3.5.6
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Currently translated at 99.8% (1084 of 1086 strings)

Translation: Datenanfragen.de/website
Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/fr/
Currently translated at 99.8% (1084 of 1086 strings)

Translation: Datenanfragen.de/website
Translate-URL: https://hosted.weblate.org/projects/datenanfragen-de/website/fr/
As per our general assembly on Dec 18, 2024.
@mal-tee mal-tee changed the base branch from master to webpack-node-staging April 13, 2026 19:45
@mal-tee mal-tee closed this Apr 13, 2026
@mal-tee mal-tee reopened this Apr 13, 2026
@baltpeter baltpeter force-pushed the webpack-node-staging branch from f093e87 to cdcc6bf Compare April 14, 2026 11:20
@@ -1,3 +1,17 @@
import Ajv from 'ajv';
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, now that I've thought about this a little, I don't think we should pull in ajv. For one, it's quite heavy (https://bundlejs.com/?q=ajv%408.18.0%2Cajv-formats%403.0.1%2Cajv-formats-draft2019%401.6.1). But more importantly, we don't want the suggest form to do validation. The current one doesn't do that either because we've decided that the suggest form is explicitly for users who don't want to deal with the intricacies of our database.

I think we should instead add an option to formj to disable validation.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get the bundle size advantage, we have to make sure that formj's built-in ajv isn't bundled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants