Skip to content

Replace Webpack, update to Node 24#1269

Draft
baltpeter wants to merge 2 commits intomasterfrom
webpack-node-staging
Draft

Replace Webpack, update to Node 24#1269
baltpeter wants to merge 2 commits intomasterfrom
webpack-node-staging

Conversation

@baltpeter
Copy link
Copy Markdown
Member

@baltpeter baltpeter commented Apr 14, 2026 •
edited
Loading

This should be rebase merged (once done).

baltpeter and others added 2 commits April 14, 2026 13:20
@baltpeter
Fixes #1211: Build JS with Hugo instead of Webpack (#1212)
cdcc6bf 
* Update to Hugo v0.140.0

This release brings various useful new esbuild features.

* Migrate JS bundles from Webpack to Hugo esbuild

* properly set NODE_ENV, fix PDF worker bundle URL

* code splitting using js.Batch

* wait for HTTP instead of TCP

* replace webpack-i18n-loader

* mostly use defines instead of generating scripts using Hugo templates

* Webpack be gone \o/

* Fixes #871: Remove `requests` scope from `I18N_DEFINITION`

* build-i18n: EN may affect translations for other langs

* address review

* build-i18n: unlink and fix allTranslations bug
@davenewham @baltpeter
Update to Node 24 (#1205)
84dc383 
Co-authored-by: Benjamin Altpeter <hi@bn.al>
@cypress
Copy link
Copy Markdown

cypress bot commented Apr 14, 2026

datenanfragen/website    Run #9239

Run Properties:  status check failed Failed #9239  •  git commit 84dc38345b: Update to Node 24 (#1205)
Project datenanfragen/website
Branch Review webpack-node-staging
Run status status check failed Failed #9239
Run duration 06m 47s
Commit git commit 84dc38345b: Update to Node 24 (#1205)
Committer David Newham
View all properties for this run ↗︎
Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 8
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 81
View all changes introduced in this branch ↗︎

Tests for review

Failed  company-database/search.spec.js • 1 failed test

View Output Video

Test Artifacts
Search for company by slug and visit company detail page > Search for and visit 1&1 single page Screenshots Video
Failed  components/advanced-generator.spec.js • 1 failed test

View Output Video

Test Artifacts
Advanced generator > loads companies from slug and clears URL parameters afterwards Screenshots Video
Failed  use-cases/generator.spec.js • 1 failed test

View Output Video

Test Artifacts
Using the generator > Simple access requests to companies in "add-all" company pack Screenshots Video
Flakiness  components/generator.spec.js • 1 flaky test

View Output

Test Artifacts
Request generator tool component > loads pdf worker for pdf only companies Screenshots
Flakiness  old-bugs/no-empty-date-in-generator.spec.js • 1 flaky test

View Output

Test Artifacts
Requests without a date should not be allowed > Deleting the date should reset to today Screenshots

@mal-tee
Copy link
Copy Markdown
Member

mal-tee commented Apr 14, 2026

I had some problems with hugo server not properly rebuilding the site when working on new preact components, but that might have been a user error :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baltpeter @mal-tee @davenewham