fix: guard against self.unit being None in Job.__repr__#655
Open
juliosuas wants to merge 1 commit intodbader:masterfrom
Open
fix: guard against self.unit being None in Job.__repr__#655juliosuas wants to merge 1 commit intodbader:masterfrom
juliosuas wants to merge 1 commit intodbader:masterfrom
Conversation
When Job.interval == 1 and self.unit is None (the initial state), __repr__ attempted self.unit[:-1] which raised: TypeError: 'NoneType' object is not subscriptable Guard both format paths in __repr__ against self.unit being None by substituting '[unit not set]' as a safe placeholder. Fixes dbader#646
Author
|
Quick note: the fix also handles the else-branch in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hit this on jobs that hadn't had a unit set yet:
self.unitis initialized toNone(there's even anOptional[str]type hint on it) but__repr__slices it unconditionally:so the moment you try to repr a freshly-constructed Job before the unit is set, it blows up. guarded both branches of the ternary with a
Nonecheck and used "[unit not set]" as placeholder text.fixes #646.