-
Notifications
You must be signed in to change notification settings - Fork 16
Add -v/--verbose flag for detailed HTTP request logging (issue #27) #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tahoora-Tabassum
wants to merge
24
commits into
dbpedia:main
Choose a base branch
from
Tahoora-Tabassum:pr-verbose-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2fb3f06
Fix --version-id -> --versionid in CLI
Tahoora-Tabassum d4bb454
Fix --version-id -> --versionid in test script
Tahoora-Tabassum 189458e
cli: add mkdist validations, completion helper, tests and docs
Tahoora-Tabassum f6f67c0
chore: refactored readme
Integer-Ctrl 49fa461
cli: delete datasets (#38)
Integer-Ctrl 0303454
refactor: split client into deploy and download
Integer-Ctrl 525ba75
refactor: iteration over download.py
Integer-Ctrl 9a95550
refactor: iteration over deploy.py
Integer-Ctrl 0cd8c5e
refactor: webdav
Integer-Ctrl 634ffd4
feat: ruff linter & formatter
Integer-Ctrl c1b8430
feat: python 3.11 migration
Integer-Ctrl a945b27
init: issue templates
Integer-Ctrl 2fc99d1
init: pr template
Integer-Ctrl 8c4cfeb
fix: wrong encoding caused wrong content lenght
Integer-Ctrl 8ff62c3
feat: batch deletions to allow cancellation before execution
Integer-Ctrl 03964ae
Restrict Vault token exchange to specific hosts; improve auth errors;…
DhanashreePetare b4bbfaa
chore: README download links
Integer-Ctrl f8aa663
Use api_deploy.create_distribution to avoid circular import
Tahoora-Tabassum 0437e1a
Add verbose CLI flag with redacted HTTP logging
Tahoora-Tabassum 5b4badd
Add verbose (-v) flag using logging; redact Authorization and X-API-K…
Tahoora-Tabassum 3cad314
Add verbose logging support and stabilize auth tests
Tahoora-Tabassum 3de6e16
* Restrict Vault token exchange to specific hosts; improve auth error…
DhanashreePetare 0471ecf
Merge branch 'main' into pr-verbose-clean
Tahoora-Tabassum cef1580
test: skip live download integration tests
Tahoora-Tabassum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| name: 'Bug Report Template' | ||
| about: Report a bug to help us improve | ||
| title: 'bug: <context of the bug>' | ||
| labels: bug | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| # Bug Report | ||
|
|
||
| **Describe the bug** | ||
| A clear and concise description of what the bug is. | ||
|
|
||
| **To Reproduce** | ||
| Steps to reproduce the behavior: | ||
| 1. Go to '...' | ||
| 2. Click on '....' | ||
| 3. Scroll down to '....' | ||
| 4. See error | ||
|
|
||
| **Expected behavior** | ||
| What you expected to happen. | ||
|
|
||
| **Screenshots (optional)** | ||
| Add screenshots if helpful. | ||
|
|
||
| **Additional context (optional)** | ||
| Anything else relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| name: 'Feature Request' | ||
| about: Suggest an idea or enhancement | ||
| title: 'feature: <feature request>' | ||
| labels: enhancement | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| # Feature Request | ||
|
|
||
| **Describe the feature you'd like** | ||
| A short description of the desired feature. | ||
|
|
||
| **Why is this feature important?** | ||
| Explain the benefit or use case. Is your feature request related to a problem? | ||
|
|
||
| **Describe alternatives you've considered** | ||
| List any alternative solutions or workarounds considered. | ||
|
|
||
| **Additional context** | ||
| Add any other details or mockups here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Pull Request | ||
|
|
||
| ## Description | ||
|
|
||
| Briefly describe the changes introduced in this PR. | ||
|
|
||
| **Related Issues** | ||
| Link any related issues (e.g., `Issue #12`). | ||
|
|
||
| ## Type of change | ||
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to change) | ||
| - [ ] This change requires a documentation update | ||
| - [ ] Housekeeping | ||
|
|
||
| ## Checklist: | ||
| - [ ] My code follows the [ruff code style](http://stellarium.org/doc/head/codingStyle.html) of this project. | ||
| - [ ] I have performed a self-review of my own code | ||
| - [ ] I have commented my code, particularly in hard-to-understand areas | ||
| - [ ] I have made corresponding changes to the documentation (if applicable) | ||
| - [ ] I have added tests that prove my fix is effective or that my feature works | ||
| - [ ] New and existing unit tests pass locally with my changes | ||
| - [ ] `poetry run pytest` - all tests passed | ||
| - [ ] `poetry run ruff check` - no linting errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| # project-specific | ||
| tmp/ | ||
| vault-token.dat | ||
|
|
||
| # Byte-compiled / optimized / DLL files | ||
| __pycache__/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Changelog | ||
|
|
||
| All notable changes to this project will be documented in this file. | ||
|
|
||
| ## [0.15] - 2025-12-31 | ||
|
|
||
| ### Added | ||
| - Vault authentication improvements with host-restricted token exchange | ||
| - Comprehensive tests for Vault authentication behavior | ||
| - Enhanced docstrings across all modules for better documentation coverage | ||
| - Support for download redirect handling | ||
|
|
||
| ### Fixed | ||
| - Vault token exchange now restricted to known hosts for improved security | ||
| - Clearer authentication error messages | ||
| - README instructions now consistent with PyPI release | ||
|
|
||
| ### Changed | ||
| - Updated CLI usage documentation to reflect current command structure | ||
| - Improved error handling in download operations | ||
|
|
||
| ### Notes | ||
| - Version 0.15 skips 0.13 and 0.14 as requested in issue #35 | ||
| - This release updates the PyPI package to align with current repository features |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| FROM python:3.10-slim | ||
| FROM python:3.11-slim | ||
|
|
||
| WORKDIR /data | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| Title: Add verbose CLI flag (-v) with redacted HTTP logging | ||
|
|
||
| Short description: | ||
| - Add a global `-v/--verbose` CLI flag to enable redacted HTTP request/response logging to help debug interactions with the Databus and Vault. | ||
|
|
||
| What changed: | ||
| - Add global `-v/--verbose` option to `databusclient` CLI and propagate it to API calls. | ||
| - Implement redacted HTTP logging helper (redacts `Authorization` and `X-API-KEY` headers). | ||
| - Instrument `download` and Vault token exchange flows to print HTTP request/response details when `-v` is enabled. | ||
| - Add unit tests ensuring verbose logs are printed and sensitive tokens are redacted. | ||
| - Update `README.md` and add a `CHANGELOG.md` entry. | ||
|
|
||
| Why: | ||
| - Provides safe, actionable debugging output for issues involving HTTP communication and auth problems without exposing secrets. | ||
|
|
||
| Security note: | ||
| - Authorization and API-key headers are redacted in verbose output. Avoid enabling verbose output in public CI logs. | ||
|
|
||
| Closes #27 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
Gr1N/setup-poetry GitHub Action maintenance status 2025💡 Result:
In 2025,
Gr1N/setup-poetryappears inactive / not actively maintained:v9(shown as released “almost 2 years ago” on the GitHub Actions registry metadata), with no newer major versions appearing in 2025. [3]Sources: [1] [2] [3]
Consider replacing
Gr1N/setup-poetrywith an actively maintained alternative.Gr1N/setup-poetry@v8has not been actively maintained since June 2024 with no updates in 2025. The latest major version (v9) was released nearly two years ago. Usesnok/install-poetryinstead, which is actively maintained and more widely adopted.🤖 Prompt for AI Agents