Skip to content

fix use-after-free in WavpackUnpackSamples after a failed seek #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aizu-m wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix use-after-free in WavpackUnpackSamples after a failed seek #254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e339caa
fix use-after-free in WavpackUnpackSamples after a failed seek
aizu-m Jun 24, 2026
0dc7d15
drop the fuzzer decode-after-failed-seek pass and regression file
aizu-m Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/unpack_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,12 @@ uint32_t WavpackUnpackSamples (WavpackContext *wpc, int32_t *buffer, uint32_t sa
WavpackStream *wps = wpc->streams [0];
int stream_index = 0;

// if the current block has no audio, or it's not the first block of a multichannel
// if we have no raw block buffered (e.g. a failed seek freed the streams), or the
// current block has no audio, or it's not the first block of a multichannel
// sequence, or the sample we're on is past the last sample in this block...we need
// to free up the streams and read the next block

if (!wps->wphdr.block_samples || !(wps->wphdr.flags & INITIAL_BLOCK) ||
if (!wps->blockbuff || !wps->wphdr.block_samples || !(wps->wphdr.flags & INITIAL_BLOCK) ||
wps->sample_index >= GET_BLOCK_INDEX (wps->wphdr) + wps->wphdr.block_samples) {
int64_t nexthdrpos;

Expand Down
Loading