cli: strip path separators from extracted binary tag filenames#258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting a binary tag item to a file (cover art,
wvunpack -xx "Field=%t") names the output after the item's embedded filename. That name is untrusted: it is the tag value bytes up to the first NUL, straight from the .wv/APEv2 tag. dump_tag_item_to_file() runs it through filespec_name() first, but filespec_name() only removes the platform's native separator:Windows treats both
/and\as separators, so on Windows a forward-slash name passes through unchanged and reaches fopen() as the output name, writing the file above the target directory. POSIX has the mirror gap: an embedded\survives (harmless there, but it is the same routine). I found it by crafting a cover-art tag whose embedded name held separators and watching where the extracted file landed.Reduce the embedded name to its final component, checking both separators, before it becomes the output name. Normal filenames are unaffected. wvtag keeps an identical copy of the function and is fixed the same way.