Volume scans going to very high densities#421
Conversation
ElliottKasoar
left a comment
There was a problem hiding this comment.
Thanks for this, @JPDarby!
I need to go through everything much more carefully, but generally it's looking great!
I've left some (largely trivial) suggestions for now
There was a problem hiding this comment.
If this is very slow even on a GPU, you could consider some sort of parameterisation, similar to #388, to make it easier to parallelise.
There was a problem hiding this comment.
So this allows different models to be run in parallel? The structure generation (now moved to run_compression) uses pyxtal and I can't guarantee that will be deterministic and produce the same random structures each time. Given this, I think it's best to avoid this for now. If the test really is too slow we could move back to generating the structures once and for all and then parametrize.
for sphinx Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
remove unused energy inflection from metrics.yml Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
marked as very_slow Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
|
Also note there are a couple of conflicting files to resolve, both hopefully pretty straightforward since it doesn't involve the code. |
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
This is similar to the diatomic test for the two-body but uses 3D crystals to probe higher body terms. For single element structures, 5 prototypes are formed (fcc, sc, bcc, hcp and diamond). A further 5 structures are randomly generated, subject to sensible constraints, using the pyxtal package. Multi-element terms are probed by picking 10 random binary and 10 random ternary compositions, then forming 10 random structures for each composition. The structures are then isotropically scaled across a wide range, covering extremely high and low densities. The energy and pressure are computed for each structure and these are used to form similar metrics to the diatomic test e.g. Pressure sign flips etc.
Linked issue
Resolves #308
Progress
Testing
Tested all models below using a subset of the elements. The
mace-mp-0amace-mp-0b3mace-mpa-0mace-omat-0mace-matpes-r2scanorb-v3-consv-inf-omatpet-madNew decorators/callbacks
Discussion Points