Add models file input option#508
Merged
ElliottKasoar merged 12 commits intoddmms:mainfrom Apr 30, 2026
Merged
Conversation
ElliottKasoar
force-pushed
the
add-model-files
branch
from
982a189 to
21b772a
Compare
Collaborator
|
think you've missed: |
ElliottKasoar
force-pushed
the
add-model-files
branch
from
21b772a to
e2e1607
Compare
Collaborator
Author
|
Good catch, thanks! This predated the merge of PR. Should be fixed now. |
joehart2001
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Allow models YAML file to be specified for all CLI commands (
ml_peg calc/analyse/app/list).I'd originally thought this may be an option parsed instead of the list of models, but I think a separate input makes sense, since then it's also filterable.
This also moves the 'global' inputs to the models init file, which means they can be accessed without the relatively heavy imports in models.py, which otherwise slow down the CLI noticeably.
Linked issue
Resolves #496
Testing
Tested locally for most commands, but could use fairly careful additional testing since it touches a lot.