Merged
Conversation
…o feat/builder-mode-support
…earable-preview into feat/spring-bones
…earable-preview into feat/spring-bones
…o feat/builder-mode-support
…earable-preview into feat/spring-bones
…o feat/spring-bones
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cyaiox
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copy of PR: #166
This pull request introduces support for spring bone physics in the preview controllers, primarily by updating dependencies and adding a physics controller for Unity, while clarifying that Babylon does not support spring bones (yet). The changes ensure that both Babylon and Unity preview controllers have a consistent interface, and Unity can now set spring bone parameters via a new method.
Spring bone physics integration:
physicsControllerto the Babylon preview controller with a no-opsetSpringBonesParamsmethod, indicating that spring bones are not supported in Babylon. (src/lib/babylon/render.ts) [1] [2]createPhysicsControllerfunction for Unity that implementssetSpringBonesParams, sending the parameters to the Unity instance via JSBridge. (src/lib/unity/physics.ts,src/lib/unity/render.ts) [1] [2] [3]Dependency update:
@dcl/schemasdependency inpackage.jsonto a DEV branch that includes spring bone support until merged (package.json)Related PRs:
Tasks