Skip to content

Fix current-main release gates #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepfates merged 1 commit into from
Jul 23, 2026
Merged

Fix current-main release gates #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/cantrip/acp/agent_handler.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,10 @@ defmodule Cantrip.ACP.AgentHandler do
runtime = :ets.lookup_element(table, :runtime, 2)
bridge = lookup_bridge(table, session_id)

with {:ok, session} <- prepare_prompt(runtime, table, session_id, session) do
prompt_prepared_runtime(runtime, table, session_id, bridge, session, text)
else
case prepare_prompt(runtime, table, session_id, session) do
{:ok, session} ->
prompt_prepared_runtime(runtime, table, session_id, bridge, session, text)

{:error, reason, next_session} ->
:ets.insert(table, {{:session, session_id}, next_session})
{:error, %ACP.Error{code: -32_002, message: Cantrip.SafeFormat.inspect(reason)}}
Expand Down
10 changes: 8 additions & 2 deletions test/cli/renderer_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ defmodule Cantrip.CLI.RendererTest do
state = Renderer.new()
event = {env(1), {:tool_call, %{gate: "read_file", tool_call_id: nil}}}
{output, _, _} = Renderer.render_event(state, event)
text = IO.iodata_to_binary(output)
text = plain_text(output)
# Depth 1 = 2 spaces prefix, then " ▸ read_file"
assert text =~ " ▸"
end
Expand All @@ -362,7 +362,7 @@ defmodule Cantrip.CLI.RendererTest do
state = Renderer.new()
event = {env(1), {:code, "done.(\"ok\")"}}
{output, _, _} = Renderer.render_event(state, event)
text = IO.iodata_to_binary(output)
text = plain_text(output)
assert text =~ " ╷"
assert text =~ " │"
end
Expand All @@ -374,4 +374,10 @@ defmodule Cantrip.CLI.RendererTest do
assert IO.iodata_to_binary(output) =~ "bash"
end
end

defp plain_text(output) do
output
|> IO.iodata_to_binary()
|> String.replace(~r/\e\[[0-?]*[ -\/]*[@-~]/, "")
end
end