improve(prometheus): merge prometheus caches#11719
Open
JinzhouChen-xmu wants to merge 1 commit into
Open
Conversation
JinzhouChen-xmu
force-pushed
the
merge_caches
branch
from
907d9c5 to
ecc8bd5
Compare
JinzhouChen-xmu
force-pushed
the
merge_caches
branch
from
ecc8bd5 to
789d735
Compare
JinzhouChen-xmu
changed the title
JinzhouChen-xmu
assigned
JinzhouChen-xmu and
SongZhen0704 and unassigned
JinzhouChen-xmu
| } | ||
| return | ||
|
|
||
| if !wait && c.refreshInterval > 0 && !c.lastRefresh.IsZero() && time.Since(c.lastRefresh) < c.refreshInterval { |
Contributor
There was a problem hiding this comment.
上次优化将 refreshInterval 默认值由 60s 改成 300s 了，cache 变成公用层在没有增量更新的情况下，应该需要改回 60s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
优化的成果（1000w条kv，实际数据300M value和label）：
实际数据
This PR is for:
Server