Implement SM120 kernel for tf32_hc_prenorm_gemm#319
Closed
ergodic-flow wants to merge 1 commit into
Closed
Conversation
This change introduces a new kernel for SM120 architecture (RTX 5090 and 6000 Pro) specifically for tf32_hc_prenorm_gemm .
Contributor
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a new kernel for SM120 architecture (RTX 5090 and 6000 Pro) specifically for
tf32_hc_prenorm_gemmas mentioned in issue #317 and issue #236 .I primarily copied what exists for
sm90, and made some adaptions until tests passed. The meat of the change will be indeep_gemm/include/deep_gemm/impls/sm120_tf32_hc_prenorm_gemm.cuhand a small shim around PTX indeep_gemm/include/deep_gemm/mma/sm120.cuh. As far as I can tell, the testtest_hyperconnection.pyappears to be passing, though the rest of the test suite is not working for me on SM120.This is a first attempt, and I am very willing to keep working at it, so please take a look if / when you have time. Supporting a new arch is a lot of work, and I hope we the community can help! Thanks, and congrats on your recent release. If the PR is not to your liking, please close it!