Remove unused imports and redundant f-string prefixes#20
Merged
Hannibal046 merged 1 commit intoJul 8, 2026
Merged
Conversation
rajpratham1
approved these changes
Jun 30, 2026
rajpratham1
left a comment
rajpratham1
left a comment
There was a problem hiding this comment.
Looks good! These are clean, non-functional changes that remove unused imports and unnecessary f-string prefixes without affecting behavior. Thanks for cleaning this up.
Maintenance cleanup (no behavior change), found with pyflakes: - Drop unused imports: `AutoTokenizer` in deepspec/eval/base_evaluator.py (DynamicCache from the same line is still used) and `math` in deepspec/utils/distributed.py. - Drop the redundant `f` prefix from `print(f"git status:", ...)` in train.py and scripts/data/prepare_target_cache.py; the f-string has no placeholders.
DaoyuanLi2816
force-pushed
the
cleanup-unused-imports-and-fstring-prefixes
branch
from
6847715 to
5b479dd
Compare
Contributor
Author
|
Heads-up: I've updated this PR so it no longer touches Since I opened it, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small maintenance cleanup found with pyflakes — no behavior change.
Unused imports
deepspec/eval/base_evaluator.py: drop unusedAutoTokenizer(DynamicCachefrom the same import is still used).deepspec/trainer/base_trainer.py: drop unusedimport os.deepspec/utils/distributed.py: drop unusedimport math.Redundant f-string prefix
train.pyandscripts/data/prepare_target_cache.py:print(f"git status:", ...)has no placeholders in the f-string, so thefis a no-op — drop it.