Skip to content

[BugFix][Engram] Support SM counts not divisible by four #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JayceSu98 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BugFix][Engram] Support SM counts not divisible by four #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tile_kernels/engram/engram_grad_w_reduce_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ def get_engram_grad_w_reduce_kernel(
blk_d = 512
assert hidden_size % blk_d == 0
num_tiles = hidden_size // blk_d
num_batches = 4
assert num_persistent_blocks % num_batches == 0
# SM90/SM100 devices can have SM counts such as 114, so avoid assuming
# that the persistent-block count is always divisible by four.
num_batches = max(batch for batch in range(4, 0, -1) if num_persistent_blocks % batch == 0)
num_rows = num_persistent_blocks // num_batches

@T.prim_func
Expand Down