Skip to content

Fix ZeRO-3 optimizer initialization validation (#7844) #7929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amadhan882 wants to merge 8 commits into
base: master
Choose a base branch
from
+1,852 −814
Open

Fix ZeRO-3 optimizer initialization validation (#7844) #7929

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a39180e
Fix: Add ZeRO-3 optimizer validation and prevent AttributeError in ba…
amadhan882 Mar 28, 2026
d931be0
Merge branch 'master' into master
sfc-gh-truwase Mar 28, 2026
ddca910
Refactor: Generalize ZeROOptimizer support and extend core APIs for B…
amadhan882 Mar 29, 2026
b36d39a
Fix: Add optimizer initialization validation and callable checks
amadhan882 Mar 29, 2026
b2e17ab
Fix: Add optimizer initialization validation for backward and ZeRO-3
amadhan882 Mar 31, 2026
0711f9b
Fix: Add ZeRO-3 specific optimizer validation and fix formatting
amadhan882 Mar 31, 2026
d749679
Merge branch 'master' into master
amadhan882 Mar 31, 2026
b1a3bc1
Merge branch 'master' into master
sfc-gh-truwase Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion deepspeed/runtime/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,15 @@ def __init__(self,

self.engine_timers_cache = {}

if self.optimizer_name() or self.client_optimizer is not None:
if self.optimizer is None:
raise RuntimeError("DeepSpeedEngine: Optimizer initialization failed. Check for JIT compilation errors.")
# ZeRO-3 specific check to prevent step 0 deadlocks
if self.zero_optimization_stage() == 3:
if not hasattr(self.optimizer, 'step'):
raise AttributeError("DeepSpeedEngine: ZeRO-3 optimizer is missing core functional attributes (.step). "
"This usually indicates a toolchain mismatch or failed JIT kernels.")

if self.global_rank == 0:
self._config.print("DeepSpeedEngine configuration")
if self.dump_state():
Expand Down Expand Up @@ -2413,7 +2422,9 @@ def allreduce_gradients(self, bucket_size=MEMORY_OPT_ALLREDUCE_SIZE):
self.optimizer.is_gradient_accumulation_boundary = self.is_gradient_accumulation_boundary()
# ZeRO stage >= 2 communicates during non gradient accumulation boundaries as well
if self.zero_optimization_partition_gradients():
self.optimizer.overlapping_partition_gradients_reduce_epilogue()
if hasattr(self.optimizer, 'overlapping_partition_gradients_reduce_epilogue'):
self.optimizer.overlapping_partition_gradients_reduce_epilogue()


# Communicate only at gradient accumulation boundaries
elif self.is_gradient_accumulation_boundary():
Expand Down
Loading