Fix/warnings stacklevel mvapich runner#7949
Draft
nathon-lee wants to merge 14 commits intodeepspeedai:masterfrom
Draft
Fix/warnings stacklevel mvapich runner#7949nathon-lee wants to merge 14 commits intodeepspeedai:masterfrom
nathon-lee wants to merge 14 commits intodeepspeedai:masterfrom
Conversation
This reverts commit ff88670. Co-authored-by: nathon-lee <248585198+nathon-lee@users.noreply.github.com>
Revert "fix: update 1 file reformatted." (ff88670)
This reverts commit b90aee5.
Revert accidental Muon optimizer code re-introduction from copilot PRs
Signed-off-by: nathon-lee <leejianwoo@gmail.com>
Collaborator
|
Hi @nathon-lee, |
Contributor
Author
Hi @tohtana, you're right — stacklevel=2 still points inside DeepSpeed, and since a RuntimeError is raised right after, users won't even see the warning. This change has no real effect. Converting to draft while I reconsider. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MVAPICHRunner.backend_existscallswarnings.warnwithoutstacklevel,so Python reports the warning as coming from inside DeepSpeed rather than
the user's code. Adding
stacklevel=2fixes the reported call site.No functional change.