Assignment 2 - Refactoring of Alitheia-Core#13
Open
nspruit wants to merge 1 commit intodelftsre:masterfrom
Open
Assignment 2 - Refactoring of Alitheia-Core#13nspruit wants to merge 1 commit intodelftsre:masterfrom
nspruit wants to merge 1 commit intodelftsre:masterfrom
Conversation
Changed testCreate call to testExecute in testShow to make sure succesid is initialized Updated AdminServiceImplTest Added first tests for DB Working on DB tests Finished DB transaction tests Added in-memory database tests Added tests for findObjectById* methods Added tests for findObjectsByProperties method Added tests for findObjectsByPropertiesForUpdate method Added dependency to H2 database (required for testing) Fixed testRegisterAdminAction test Added tests for find* methods when there is no active session Added some tests for adding and deleting records Added HQL test cases Added test for attachObjectToDBSession Added test for executeUpdate Introducing consistency to tests Cleaned up DBHQLQueryTest Moved DBObject Wrote tests for ConfigurationOption Added integration tests for the DB calls in Metric Introduced new interfaces for DB Created basic implementation for DBSessionManager Further refactored the transaction management Fixed DB transaction tests Fixed DB HQL tests Now, all tests are changed according to the refactoring Copied log methods from DBServiceImpl to DBSessionManagerImpl for now Updated all calls to session management functions Updated all calls to the session manager Implementing (HQL)QueryInterface Removed HQL from DBSession(Impl) API Restructured query interface tests Refactored QueryInterace usage in tests Refactored QueryInterface access Updated all query interface calls Reverted the changes to the path Implemented SQLQueryInterface Working on refactoring the exception handling of the DB services Finished extraction of DB log functions Fixed small bugs with log functions Added and deleted some comments Created QueryInterfaceFactory to facilitate runtime plugging of new interfaces Cleaned up factory registration Added more documentation Added tests for query interface retrieval/registration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code belonging to assignment 2, by Tim Hegeman (4145585) and Niels Spruit (4137639)