Emil Kleszcz & Piotr Swierczynski Refactoring#19
Open
swierszczu4j wants to merge 1 commit intodelftsre:masterfrom
Open
Emil Kleszcz & Piotr Swierczynski Refactoring#19swierszczu4j wants to merge 1 commit intodelftsre:masterfrom
swierszczu4j wants to merge 1 commit intodelftsre:masterfrom
Conversation
Test and first attempt of refactoring Spline class IDList tests and class improvement according to SRP violation Refactoring next stage Commit fixes Tension errors resolved Added comment to SplineConverter Test for CurveAndSurfaceMath Moved Spline tests to test folder Test for CurveAndSurfaceMath.intepolateNurb before refactoring Test Reorder over packages Moved another tests from math and shape to correct test package Test for MotionPath class Test with Mock for IDListPlainTextPrinter class and modification of IDList and IDListPlainTextPrinter Commit fixes 2 Applied refactoring to Spline class Refactoring improvement Modified public fields into private in IDList and all the dependecies Change name of previous test to refactor test SplineType Curve refactor Extracting methods from interface Savable in Spline class Add new class SplineSavable to server Spline with write and read methods Savable interface tests (Spline class) Final changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test and first attempt of refactoring Spline class
IDList tests and class improvement according to SRP violation
Refactoring next stage
Commit fixes
Tension errors resolved
Added comment to SplineConverter
Test for CurveAndSurfaceMath
Moved Spline tests to test folder
Test for CurveAndSurfaceMath.intepolateNurb before refactoring
Test Reorder over packages
Moved another tests from math and shape to correct test package
Test for MotionPath class
Test with Mock for IDListPlainTextPrinter class and modification of
IDList and IDListPlainTextPrinter
Commit fixes 2
Applied refactoring to Spline class
Refactoring improvement
Modified public fields into private in IDList and all the dependecies
Change name of previous test to refactor test
SplineType
Curve refactor
Extracting methods from interface Savable in Spline class
Add new class SplineSavable to server Spline with write and read methods
Savable interface tests (Spline class)
Final changes