Skip to content

[stable/node-local-dns] Make liveness probe configurable #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paddy-bedraggled wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[stable/node-local-dns] Make liveness probe configurable #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/node-local-dns/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: node-local-dns
version: 2.7.0
version: 2.7.1
appVersion: 1.26.7
maintainers:
- name: gabrieladt
Expand Down
14 changes: 12 additions & 2 deletions stable/node-local-dns/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# node-local-dns

![Version: 2.7.0](https://img.shields.io/badge/Version-2.7.0-informational?style=flat-square) ![AppVersion: 1.26.7](https://img.shields.io/badge/AppVersion-1.26.7-informational?style=flat-square)
![Version: 2.7.1](https://img.shields.io/badge/Version-2.7.1-informational?style=flat-square) ![AppVersion: 1.26.7](https://img.shields.io/badge/AppVersion-1.26.7-informational?style=flat-square)

A chart to install node-local-dns.

Expand All @@ -23,7 +23,7 @@ helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-d
To install a specific version of this chart:

```console
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-dns --version 2.7.0
helm install --generate-name oci://ghcr.io/deliveryhero/helm-charts/node-local-dns --version 2.7.1
```

To install the chart with the release name `my-release`:
Expand Down Expand Up @@ -82,6 +82,16 @@ helm install my-release oci://ghcr.io/deliveryhero/helm-charts/node-local-dns -f
| image.tag | string | `""` | Overrides the image tag whose default is the chart appVersion. |
| imagePullSecrets | list | `[]` | |
| initContainers | list | `[]` | |
| livenessProbe | object | `{"failureThreshold":null,"httpGet":{"host":"","path":"/health","port":null,"scheme":"HTTP"},"initialDelaySeconds":60,"periodSeconds":null,"successThreshold":null,"timeoutSeconds":5}` | Liveness probe configuration for the node-cache container. |
| livenessProbe.failureThreshold | string | `nil` | When a probe fails, Kubernetes will try failureThreshold times before giving up. |
| livenessProbe.httpGet.host | string | `""` | Host used for the liveness probe HTTP request. Leave empty to use the pod IP. |
| livenessProbe.httpGet.path | string | `"/health"` | Path used for the liveness probe HTTP request. |
| livenessProbe.httpGet.port | string | `nil` | Port used for the liveness probe HTTP request. Defaults to config.healthPort when unset. |
| livenessProbe.httpGet.scheme | string | `"HTTP"` | Scheme used for the liveness probe HTTP request. |
| livenessProbe.initialDelaySeconds | int | `60` | |
| livenessProbe.periodSeconds | string | `nil` | How often in seconds to perform the probe. |
| livenessProbe.successThreshold | string | `nil` | Minimum consecutive successes for the probe to be considered successful after having failed. |
| livenessProbe.timeoutSeconds | int | `5` | |
| nameOverride | string | `""` | |
| podAnnotations | object | `{}` | |
| podLabels | object | `{}` | |
Expand Down
23 changes: 19 additions & 4 deletions stable/node-local-dns/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,25 @@ spec:
protocol: TCP
livenessProbe:
httpGet:
path: /health
port: {{ .Values.config.healthPort }}
initialDelaySeconds: 60
timeoutSeconds: 5
path: {{ .Values.livenessProbe.httpGet.path | quote }}
port: {{ default .Values.config.healthPort .Values.livenessProbe.httpGet.port }}
{{- with .Values.livenessProbe.httpGet.host }}
host: {{ . | quote }}
{{- end }}
{{- with .Values.livenessProbe.httpGet.scheme }}
scheme: {{ . }}
{{- end }}
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }}
{{- with .Values.livenessProbe.periodSeconds }}
periodSeconds: {{ . }}
{{- end }}
{{- with .Values.livenessProbe.successThreshold }}
successThreshold: {{ . }}
{{- end }}
{{- with .Values.livenessProbe.failureThreshold }}
failureThreshold: {{ . }}
{{- end }}
volumeMounts:
- mountPath: /run/xtables.lock
name: xtables-lock
Expand Down
20 changes: 20 additions & 0 deletions stable/node-local-dns/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,26 @@ config:
# -- Allows for configuration of upstream server forwarding for the default server block
upstreamForwardConfig: {}

# -- Liveness probe configuration for the node-cache container.
livenessProbe:
httpGet:
# -- Host used for the liveness probe HTTP request. Leave empty to use the pod IP.
host: ""
# -- Path used for the liveness probe HTTP request.
path: /health
# -- Port used for the liveness probe HTTP request. Defaults to config.healthPort when unset.
port:
# -- Scheme used for the liveness probe HTTP request.
scheme: HTTP
initialDelaySeconds: 60
timeoutSeconds: 5
# -- How often in seconds to perform the probe.
periodSeconds:
# -- Minimum consecutive successes for the probe to be considered successful after having failed.
successThreshold:
# -- When a probe fails, Kubernetes will try failureThreshold times before giving up.
failureThreshold:

nameOverride: ""
fullnameOverride: ""

Expand Down
Loading