Some improvements for packaged build [wip]#82
Closed
noiseless wants to merge 3 commits into
Closed
Conversation
Contributor
Oh. Every time someone tries to do this, snap package breaks. So this would need extensive testing across all the building configuration. |
ilya-fedin
reviewed
Dec 29, 2021
| include(cmake/libusrsctp.cmake) | ||
| include(cmake/libvpx.cmake) | ||
| include(cmake/libyuv.cmake) | ||
| if (NOT TG_OWT_PACKAGED_BUILD) |
Contributor
There was a problem hiding this comment.
This breaks the fallback logic when a library is not found
Contributor
There was a problem hiding this comment.
Yes, that can't be right.
#85 should do the trick, though.
Author
There was a problem hiding this comment.
Yes, this is wrong, as Ilya has already told me. 5986975 should fix that.
(However, there are linking problems with snap pack builds there; I haven't had a chance to reproduce it yet, but I'm still going to)
c5fc0b3 to
5986975
Compare
Integrated the Vitaly Lipatov's (lav@altlinux.ru) patch. It allows to build tg_owt with the system libyuv. If libyuv is not installed on the system, the build will be performed with libyuv from src/third_party/. Also fixed build in non-packaged mode.
c18ef25 to
ddcb55f
Compare
Contributor
|
Is there still any work? Maybe close the PR and re-open when you would have time? |
Author
|
reasonably |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to share you my suggestions for improving TG_OWT_PACKAGED_BUILD.
Here they are:
The patch adds cmake rules for building tg_owt with libyuv from the system/packages.
Testing.
To test my changes I did the following:
To apply my changes, I replaced these lines in
centos_env/Dockerfilefromto
and also edited .gitmodules:
The build was successful.
2) I did a packaged build under OpenBSD. Tested situations where libyuv is installed on the system and where it is not there, but everything you need is in
./src/third_party/libyuv.In the first case, tg_owt was built with libyuv from the package, in the second, from
./src/third_party/libyuv, i.e. everything is as expected.What do you think of my patches? If necessary, I am ready to improve them according to your wishes.
Perhaps I should test some other build variants?
Thanks anyway.